Skip to content

feat: flag review-required kanban tasks#65

Open
HODLCLONE wants to merge 1 commit into
liftaris:devfrom
HODLCLONE:feat/review-required-kanban-rebased
Open

feat: flag review-required kanban tasks#65
HODLCLONE wants to merge 1 commit into
liftaris:devfrom
HODLCLONE:feat/review-required-kanban-rebased

Conversation

@HODLCLONE

Copy link
Copy Markdown

Summary

  • derive review_required / review_count for Kanban tasks from review-required comments
  • show a compact ⚑ marker and inline review count on one-line Kanban cards while preserving existing diagnostics severity glyphs
  • cover board reader and TUI render behavior in Kanban tests

Test Plan

  • npx --yes bun@latest install
  • npx --yes bun@latest test test/kanban.test.tsx --timeout 30000
  • npx --yes bun@latest test
  • npx --yes bun@latest x tsc --noEmit

@HODLCLONE

Copy link
Copy Markdown
Author

Hermes QA Review

Verdict: LGTM / no blocking findings.

Reviewed the diff for review-required Kanban surfacing in:

  • src/service/hermes-kanban.ts
  • src/tabs/Kanban.tsx
  • test/kanban.test.tsx

Checks run locally on HODLCLONE:feat/review-required-kanban-rebased:

  • git diff --check origin/dev...HEAD passed
  • npx --yes bun@latest test test/kanban.test.tsx --timeout 30000 passed: 51 pass, 0 fail
  • npx --yes bun@latest test passed: 955 pass, 11 skip, 0 fail
  • npx --yes bun@latest x tsc --noEmit passed

Security/quality notes:

  • No hardcoded secrets, filesystem writes, shell execution, or user-input command construction introduced.
  • The new SQLite query is read-only and uses a static query; no injection surface found.
  • Existing diagnostics glyph behavior is preserved; the review flag/count is appended inline on one-line cards.
  • The read path handles missing/older task_comments schemas by falling back to no review markers, matching the surrounding fault-tolerant reader style.

Minor non-blocking observation: this intentionally treats any persisted comment containing review-required as a durable marker, so the flag can remain visible after later unblock/review comments unless a future state-clearing convention is added.

@liftaris liftaris force-pushed the feat/review-required-kanban-rebased branch from 8a0636f to b181f16 Compare June 15, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant