fix(benchmarks): remove unused @ts-expect-error directive#5339
fix(benchmarks): remove unused @ts-expect-error directive#5339Raphael005 wants to merge 2 commits into
Conversation
The dynamic import of 'lit-element/lib/decorators.js' no longer produces a TS error, making the @ts-expect-error suppression stale and causing TS2578 to fail the build. Co-Authored-By: Oz <oz-agent@warp.dev>
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Co-Authored-By: Oz <oz-agent@warp.dev>
Summary
Fixes a
TS2578build error inpackages/benchmarks/lit-element/list/index.ts.Problem
The
@ts-expect-errordirective on the dynamic import oflit-element/lib/decorators.jswas added to suppress a TypeScript error that no longer occurs. With strict TypeScript checking, an unused@ts-expect-erroris itself an error:Fix
Remove the stale
// @ts-expect-errordirective and its accompanying// eslint-disable-next-line @typescript-eslint/ban-ts-commentcomment. The dynamic import is already cast viaas unknown as typeof import(...)so no type suppression is needed.Generated with Oz
Co-Authored-By: Oz oz-agent@warp.dev