fix: adding required permissions to top level and jobs in the workflow#12951
Open
gaganhr94 wants to merge 1 commit into
Open
fix: adding required permissions to top level and jobs in the workflow#12951gaganhr94 wants to merge 1 commit into
gaganhr94 wants to merge 1 commit into
Conversation
4aeb489 to
c2e23fc
Compare
Signed-off-by: Gagan H R <hrgagan4@gmail.com>
c2e23fc to
a3a2375
Compare
Member
|
I will review the changes again later to ensure no workflows are impacted. |
Contributor
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #12950
Fixes #12950
What this PR does / why we need it:
Currently the score for the Token Permissions is 0 because the top level permissions and a few job level permissions are missing in the workflows. With this change, the score will move to 10, since the workflow jobs will run with the minimal permissions. The PR retains conditions like
writeonly at the job level, where it is necessary.Special notes for your reviewer:
This change only touches
.github/workflows/*.yml/.yamlfiles to addpermissions:blocks (top-levelcontents: readby default, with elevatedwritepermissions kept only at the job level where needed). No application code, docs, helm chart, or CHANGELOG changes are required.Additional documentation or context