DEP: remove upper pin on esda#255
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=====================================
Coverage 88.2% 88.2%
=====================================
Files 10 10
Lines 1584 1584
=====================================
Hits 1397 1397
Misses 187 187 🚀 New features to boost your workflow:
|
|
@martinfleis - See #241 |
|
Last weekend I started for a fix, but then found that stuff being getting in the way over in |
|
I just found it, thanks. For that we ideally need to cut new esda to simplify the version checks. Also, the crand change should happen in esda 3.0.0, so the upper pin is wrong anyway. I suggest removing it as I believe we can adapt to the change before it will come. |
jGaboardi
left a comment
There was a problem hiding this comment.
I am OK with this, but let's wait for @weikang9009's explicit approval to merge.
|
@weikang9009 if you want to be careful here, I can update the pin to the proper version as this currently disallows latest esda for no reason. |
|
Also xref - pysal/pysal#1436 |
Sounds like a good plan! |
Since @weikang9009 explicitly consented to this. I think it's safe to merge. |
Any idea why does this exist? Locally, all tests run against esda main. It is breaking my local dev environment :D. I have a vague memory of seeing a reason somewhere but can't find it. I'd be keen to fix it if there is an actual issue.