TEST: Add test for _installed_version with nonexistent package#1408
Open
nimra06 wants to merge 2 commits into
Open
TEST: Add test for _installed_version with nonexistent package#1408nimra06 wants to merge 2 commits into
nimra06 wants to merge 2 commits into
Conversation
- Add test_installed_version_for_nonexistent_package() method - Remove outdated comment about NameError bug - Verifies function correctly returns 'NA' for nonexistent packages
Member
|
@nimra06 please update this PR against current |
Author
|
@jGaboardi Updated the PR with the current main. Thanks for the review! |
sjsrey
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Adds the missing test case for _installed_version() when called with a nonexistent package. The function correctly returns 'NA', but the test was never added (there was a comment saying it was skipped due to a bug that doesn't actually exist).
Changes
Checklist
pysal/mainbranchRelated
Closes #1407