Skip to content

pkp/pkp-lib#12841 Infrastructural support of laravel logging#5568

Open
touhidurabir wants to merge 2 commits into
pkp:mainfrom
touhidurabir:i12841_main
Open

pkp/pkp-lib#12841 Infrastructural support of laravel logging#5568
touhidurabir wants to merge 2 commits into
pkp:mainfrom
touhidurabir:i12841_main

Conversation

@touhidurabir

Copy link
Copy Markdown
Member

Comment thread config.TEMPLATE.inc.php Outdated
Comment on lines +605 to +606
; Defaults to {application name}.log (e.g. ojs2.log, omp2.log, ops2.log).
; log_file_name = ojs2.log

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we're using the 2 suffix? I'm even thinking we shouldn't name the log specific to each application; we could just call it error_log or something similar.

In fact, is there a benefit to making the name configurable at all?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we're using the 2 suffix?

that's just as an example using same application name .

we could just call it error_log or something similar.

we can name it whatever we want to but better to named it as error_log which will confuse with PHP's default error log . and log does not only contains error but any debug, info, alert (basically any PSR log level) so error_log name does not justify it also .

In fact, is there a benefit to making the name configurable at all?

Truthfully not much , it's just a convenience. currently default named to application's name but we can have simple logs.log as default also . and not make it configurable .

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just fix it as system.log or something. Filenames in the files directory shouldn't be configurable; they should be named consistently.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say go for app.log as it is app's own log .

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed configurable log file name ability and set the log file name to app.log .

@touhidurabir touhidurabir force-pushed the i12841_main branch 2 times, most recently from 3943e6a to 263bf77 Compare June 10, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants