pkp/pkp-lib#12841 Infrastructural support of laravel logging#5568
pkp/pkp-lib#12841 Infrastructural support of laravel logging#5568touhidurabir wants to merge 2 commits into
Conversation
| ; Defaults to {application name}.log (e.g. ojs2.log, omp2.log, ops2.log). | ||
| ; log_file_name = ojs2.log |
There was a problem hiding this comment.
Is there any reason we're using the 2 suffix? I'm even thinking we shouldn't name the log specific to each application; we could just call it error_log or something similar.
In fact, is there a benefit to making the name configurable at all?
There was a problem hiding this comment.
Is there any reason we're using the 2 suffix?
that's just as an example using same application name .
we could just call it error_log or something similar.
we can name it whatever we want to but better to named it as error_log which will confuse with PHP's default error log . and log does not only contains error but any debug, info, alert (basically any PSR log level) so error_log name does not justify it also .
In fact, is there a benefit to making the name configurable at all?
Truthfully not much , it's just a convenience. currently default named to application's name but we can have simple logs.log as default also . and not make it configurable .
There was a problem hiding this comment.
I think we should just fix it as system.log or something. Filenames in the files directory shouldn't be configurable; they should be named consistently.
There was a problem hiding this comment.
I say go for app.log as it is app's own log .
There was a problem hiding this comment.
removed configurable log file name ability and set the log file name to app.log .
3943e6a to
263bf77
Compare
69f4f1b to
7400c76
Compare
for pkp/pkp-lib#12841 .