Skip to content

feat: Add flag to override output destination#121

Open
thaney071 wants to merge 1 commit into
posener:masterfrom
thaney071:feature/100-add-flag-override-output-dest
Open

feat: Add flag to override output destination#121
thaney071 wants to merge 1 commit into
posener:masterfrom
thaney071:feature/100-add-flag-override-output-dest

Conversation

@thaney071

@thaney071 thaney071 commented Mar 20, 2022

Copy link
Copy Markdown

Adds a flag to override the destination output.

The reason for adding a flag override in addition to the env setting is for easier usage with go generate and for automated scripting of readme generations since all other options are controled by flags.

This provides better access to using this tool for those not able to use Github actions.

Closes #100

@thaney071 thaney071 marked this pull request as ready for review March 20, 2022 03:06
@codecov

codecov Bot commented Mar 20, 2022

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (bbdf026) to head (6291301).
Report is 40 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files           3        3           
  Lines          81       81           
=======================================
  Hits           56       56           
  Misses         15       15           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posener

posener commented Mar 20, 2022

Copy link
Copy Markdown
Owner

Hi!
Note that the default behavior is to write the content to stdout.
Maybe you can pipe stdout to a file of your choice?
I would want to avoid adding too many flags.

Also - I suggest to split this to two PRs, one that adds the flag, and one that creates the parent directory in case it does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag for output destination

2 participants