cortex-m: keep state during single-step to disambiguate halt reason#4040
Open
9names wants to merge 1 commit into
Open
cortex-m: keep state during single-step to disambiguate halt reason#40409names wants to merge 1 commit into
9names wants to merge 1 commit into
Conversation
ded193e to
a98066d
Compare
Contributor
|
Hi @9names , I tested this on my target and it works great! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Cortex-M, DFSR.HALTED is set by
C_HALTandC_STEP, so GDB single-step completion (C_STEP) looked the same as an explicit halt (C_HALT).See https://developer.arm.com/documentation/ddi0403/d/Debug-Architecture/ARMv7-M-Debug/Debug-register-support-in-the-SCS/Debug-Fault-Status-Register--DFSR
Add a
pending_stepflag inCortexMStatefor the duration ofC_STEP, and use that to resolve to the correct halt reason inCoreInterface::status().Resolves #4030