pull comments link from article when fetching feeds from sync provider#1215
Open
TateWalker wants to merge 2 commits into
Open
pull comments link from article when fetching feeds from sync provider#1215TateWalker wants to merge 2 commits into
TateWalker wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching articles from GReader-compatible sync providers (e.g. FreshRSS), the
commentsUrlfield was alwaysnull. This addsextractCommentsUrlto theHtmlParserinterface and implements it on both JVM/Android (Jsoup) and iOS (SwiftSoup) by finding the first anchor whose text is "Comments" (case-insensitive).The
ItemContentDTOMappernow calls this parser method on article content HTML to populatecommentsUrlwhen present.Changes
extractCommentsUrl(html)toHtmlParserinterface with JVM and iOS implementationsItemContentDTOMapperto extract the comments URL from article content instead of always returning nullHtmlParserimplementations in tests to satisfy the new interface methodJvmHtmlParserandItemContentDTOMappercovering present, absent, null-content, and case-insensitive scenarios