Fix Playback#40
Open
JLaferri wants to merge 12 commits into
Open
Conversation
JLaferri
commented
Jul 30, 2025
|
|
||
| if (slippi_exi != nullptr) | ||
| slippi_exi->ConfigureJukebox(); | ||
| #endif // IS_PLAYBACK |
Member
Author
There was a problem hiding this comment.
I added this because firstly I dont think jukebox is needed when playback is enabled but also I was getting an error with the EXISlippi files not being found or something.
* Fix playback build on linux. * playback flag
0cb02d9 to
5ee04fd
Compare
This reverts commit 4d91826.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.