ENH: Python 3.12 and NumPy 2.0 compat#6744
Draft
larsoner wants to merge 7 commits into
Draft
Conversation
larsoner
commented
Jul 24, 2024
| # otherwise, just get the requested group | ||
| entryPoints += importlib.metadata.entry_points().get(group, []) | ||
|
|
||
| return entryPoints |
Contributor
Author
There was a problem hiding this comment.
There was a lot of code dup here with the psychopy.plugins.util.getEntryPoints so I got rid of this version. I replaced it above in the one place it was used hoping it's equivalent.
This reverts commit 445e5f5.
Contributor
|
@larsoner Does this wheel of PTB work on osx-arm architect? That will be fantastic! |
Contributor
Author
|
No that will be a separate paid feature sounds like, see Psychtoolbox-3/Psychtoolbox-3#813 (comment) |
Contributor
|
Hmm... that's annoying but very understandable. |
Member
|
I reached out to Mario to discuss funding the work back in May and haven't heard back but maybe the email got lost in the cracks. I'll try again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked briefly for open issues or PRs about NumPy 2.0 and Python 3.12 compat and didn't see any. So I started digging and opened aforren1/ptb-wheels#10, Psychtoolbox-3/Psychtoolbox-3#843, aforren1/Psychtoolbox-3#1 which should fix Psychtoolbox and make 3.12 + NumPy 2.0 compatible psychtoolbox wheels available 🤞 . Locally I can at least get
psychtoolboxto import on my 3.12 + NumPy 2.0 system with those changes.This PR contains some additional stuff I needed to get
$ psychopyto open when using the wheel above.setuptoolswas needed (and an upper bound pin) in the runtime dependencies so I removed it, but happy to put it back.So some opinionated choices in here, happy to modify as needed or close if someone is already working on this and I missed it!