Execute go commands in subshell w/ repo working directory#6
Open
jmwample wants to merge 1 commit intoqdeconinck:conext17from
Open
Execute go commands in subshell w/ repo working directory#6jmwample wants to merge 1 commit intoqdeconinck:conext17from
jmwample wants to merge 1 commit intoqdeconinck:conext17from
Conversation
Owner
|
Thanks for your contribution. However, I'm not sure if this is actually useful/compatible with old 1.9 Go version. Another point is that you target your PR on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions of golang centered around modules require the context of the module files to build or run golang programs. Running from the working directory of the scripts fails for newer versions of golang.
By running the go commands (build for Quic, and run for QuicReqres) in a subshell the working directory of the script is preserved and the module files can be properly accessed.
This solution works for golang 1.17.7 and should be backwards compatible to 1.9.2+ which the original artifacts use (should because packages don't compile properly on 1.9.2 anymore).