Conversation
There was a problem hiding this comment.
This PR is not ready for merging. There are too many unrelated changes and additions compared to the claimed contribution of this PR. You should rework your commits to have a cleaner history, possibly squashing them.
Also, please keep overall communications in English, including the PR messages.
README.rst
Outdated
|
|
||
| Usage | ||
| ===== | ||
| Each experiment is defined by a *topology file* (``.para``) and an *experiment file* (``.xp``) |
There was a problem hiding this comment.
There is no .para nor .xp file extensions here.
README.rst
Outdated
| cargo build --release --bin http3-server --bin http3-client | ||
|
|
||
| After compilation, you can use the following binaries in your experiment files: | ||
|
|
||
| - ``target/release/quiche-server`` | ||
| - ``target/release/quiche-client`` |
There was a problem hiding this comment.
This command does not generate the quiche-client and quiche-server files. It should instead build quiche-client and quiche-server (not http3-client and http3-server).
README.rst
Outdated
| basic Example | ||
| ============= | ||
| This section describes a complete example showing how to establish | ||
| a **SP QUIC** connection using this framework. |
README.rst
Outdated
| 1. Launch the topology | ||
| ---------------------- | ||
|
|
||
| Start a multi-interface topology (in our case ``topo_2``) **without any experiment** |
There was a problem hiding this comment.
It would make more sense to describe a bit the network topology that this file is creating.
README.rst
Outdated
| This opens the interactive Mininet CLI with the nodes already connected | ||
| (client, router, server). | ||
|
|
||
| --- |
There was a problem hiding this comment.
The remaining sections sounds overly complicated in a README. Why not having all these interactions in the experience file directly? Maybe you could provide a simpler case than running a QUIC experiment if you want to show some CLI interactions.
| """ | ||
| Matches the name of the topo and find the corresponding Topo class. | ||
| """ | ||
| """Matches the name of the topo and find the corresponding Topo class.""" |
There was a problem hiding this comment.
Please remove such similar changes that are unrelated to the YAML support.
There was a problem hiding this comment.
Please discard all changes to that file.
There was a problem hiding this comment.
I did not reviewed that file, though it appear to have several flaws already raised in my previous comments (unneeded changes, inclusion of non-English comments,...).
Summary
This Pull Request introduces YAML support for topology configuration files.
The runner automatically detects the input format and loads the appropriate parser.
Changes
runner.pytopo_1.yamltotopo_5.yaml)README.rstwith a short YAML example and usage instructionsRationale
YAML files provide a clearer structure, improved readability, and make it easier
to extend topology descriptions in future contributions.
This PR introduces YAML support without modifying the default behavior for
existing users.
Testing
Tested using: