fix: preserve empty min_should filter semantics#9396
Open
Varunsls wants to merge 1 commit into
Open
Conversation
timvisee
requested changes
Jun 9, 2026
Comment on lines
78
to
-79
| }) = filter.min_should.as_ref() | ||
| && !conditions.is_empty() |
Member
There was a problem hiding this comment.
I don't think this is valid.
An empty list with min_should == 0 (which is an accepted value) should still match everything.
I opened a PR at roughly the same time here: #9401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9369.
Summary
min_shouldclauses were removed during filter optimization.min_count > 0from match-none to match-all.Testing
min_count = 0andmin_count = 1cargo test -p segment --libcargo test -p segment --test integrationcargo clippy -p segment --lib --tests -- -D warningscargo +nightly fmt --all -- --checkAI disclosure
Code reviewed by AI for any possible optimization.