Skip to content

Fix issue 148 with controlled/uncontrolled inputs #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DjebbZ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue 148 with controlled/uncontrolled inputs #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions project.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
[rum "0.11.2" :exclusions [sablono]]]
:plugins [[lein-cljsbuild "1.1.7"]
[lein-doo "0.1.10"]
[lein-figwheel "0.5.15"]
[lein-figwheel "0.5.16-SNAPSHOT"]
[perforate "0.3.4"]]
:resource-paths ["test-resources" "target"]}
:provided {:dependencies [[cljsjs/create-react-class "15.6.2-0"]
Expand All @@ -39,7 +39,7 @@
[{:id "devcards"
:compiler
{:asset-path "devcards"
:aot-cache true
;:aot-cache true
:main sablono.test.runner
:output-to "target/public/sablono.js"
:output-dir "target/public/devcards"
Expand All @@ -52,7 +52,7 @@
{:id "benchmark"
:compiler
{:asset-path "target/benchmark/out"
:aot-cache true
;:aot-cache true
:main sablono.benchmark
:npm-deps
{:benchmark "1.0.0"
Expand All @@ -69,7 +69,7 @@
{:id "nodejs"
:compiler
{:asset-path "target/nodejs/out"
:aot-cache true
;:aot-cache true
:main sablono.test.runner
:npm-deps
{:benchmark "1.0.0"
Expand All @@ -87,7 +87,7 @@
{:id "none"
:compiler
{:asset-path "target/none/out"
:aot-cache true
;:aot-cache true
:main sablono.test.runner
:output-to "target/none/sablono.js"
:output-dir "target/none/out"
Expand All @@ -99,7 +99,7 @@
{:id "advanced"
:compiler
{:asset-path "target/advanced/out"
:aot-cache true
;:aot-cache true
:main sablono.test.runner
:output-dir "target/advanced/out"
:optimizations :advanced
Expand All @@ -116,7 +116,7 @@
{:id "sample"
:compiler
{:asset-path "target/sample/out"
:aot-cache true
;:aot-cache true
:main example.core
:output-dir "target/sample/out"
:output-to "target/sample/sablono.js"
Expand Down
8 changes: 7 additions & 1 deletion test/sablono/input_test.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
(ns sablono.input-test
(:require [clojure.pprint :refer [pprint]]
[devcards.core :refer-macros [defcard]]
[rum.core :as rum]))
[rum.core :as rum]
[sablono.core :refer [html] :refer-macros [html]]))

(def fruits
[["grapefruit" "Grapefruit"]
Expand Down Expand Up @@ -108,3 +109,8 @@

(defcard select-toggle-issue-145
(select-toggle (atom ["1st" "2nd" "3rd"])))

(defcard input-conflict-issue-148
(html [:div [:input {:type "text"
:value "hello world"
:on-change (fn [e] (println e))}]]))