Use shared references for MemReader methods#157
Merged
gabrielesvelto merged 1 commit intorust-minidump:mainfrom Sep 26, 2025
Merged
Use shared references for MemReader methods#157gabrielesvelto merged 1 commit intorust-minidump:mainfrom
gabrielesvelto merged 1 commit intorust-minidump:mainfrom
Conversation
gabrielesvelto
approved these changes
Sep 22, 2025
Contributor
gabrielesvelto
left a comment
There was a problem hiding this comment.
Excellent, just one nit
| std::sync::OnceLock, | ||
| }; | ||
|
|
||
| #[derive(Debug)] |
Contributor
There was a problem hiding this comment.
Is the Debug trait required or can it be removed? I wouldn't add it unless the structure is user-printable.
Collaborator
Author
There was a problem hiding this comment.
Yep -- This is needed to be able to use Result::expect() on the potential Err(Style) that might be returned by OnceLock::set(). Alternatively, I could use .ok().expect(...) on it to avoid this, but honestly this is an internal type anyway - What's the point of avoiding #[derive(Debug)] on it?
Contributor
There was a problem hiding this comment.
It was just to avoid unnecessary codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnceLockis perfect for situations like this, where a one-time memoization needs to be done and then the object will never mutate again.Now we can use shared references for
MemReader, which is nice because sometimes it can be awkward not being able to read two areas of the other process's memory concurrently (despite there being no reason it can't be done).