fix(react-hook-form): initialize useFieldArray via reset on first data load (fixes #7401)#7402
Open
Woutuuur wants to merge 2 commits into
Open
fix(react-hook-form): initialize useFieldArray via reset on first data load (fixes #7401)#7402Woutuuur wants to merge 2 commits into
Woutuuur wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4cf635b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
79d9b77 to
d1f2537
Compare
This was referenced May 11, 2026
1dbe02a to
4cf635b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7401.
PR Checklist
https://refine.dev/docs/guides-concepts/contributing/#commit-convention
Bugs / Features
What is the current behavior?
When using
useFieldArrayinside a form powered byuseForm, the fields array is empty on render even though the API response contains data. This happens consistentlyin cases where the component is retriggered when React Query has cached data.This seems to mostly affect cases where the
useFieldArrayrender depends onformLoading, e.g.:See https://codesandbox.io/p/sandbox/t6pxft for a minimal replication.
What is the new behavior?
useFieldArray.fieldscorrectly reflects the array data from the API response.Notes for reviewers
useFieldArraymust be mounted and initialized beforesetValuecalls can populate it. With cached React Query data, the response is served immediately while also starting a background refetch, soquery.datais already set when the component mounts, butformLoadingistrue(driven byisFetching). The[query.data]effect fires right away, but ifuseFieldArrayis behind a loading guard based onformLoadingat that point, thesetValuecalls from applyValuesToFields are a no-op. WhenformLoadingturnsfalse,query.datais the same object reference and the effect does not re-fire. In the end,useFieldArraymounts butfieldsstays empty.The fix calls
reset({ ...getValues(), ...data }, { keepDirtyValues: true })on the first data laod. UnlikesetValue,resetsets the form's default values directly, souseFieldArraycan initialize from them whenever. Merging withgetValues()preserves any fields present in the form but absent from the API response.keepDirtyValues: truepreserves values the user has already edited. Subsequent data loads use the existingapplyValuesToFields.