Skip to content

Fix for: f-slash for non-existent directories #29#42

Open
nikitazu wants to merge 2 commits into
rejeep:masterfrom
nikitazu:f-slash-not-existent-directories
Open

Fix for: f-slash for non-existent directories #29#42
nikitazu wants to merge 2 commits into
rejeep:masterfrom
nikitazu:f-slash-not-existent-directories

Conversation

@nikitazu

Copy link
Copy Markdown

Lets temporary override the behaviour of f-slash.

The discussion is in issue 29.

rejeep and others added 2 commits April 15, 2015 10:47
When this variable is set to true, it changes the behaviour
of f-slash to always return paths with slashes on the end.
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 97.46% when pulling cd6504f on nikitazu:f-slash-not-existent-directories into 0541011 on rejeep:master.

@rejeep

rejeep commented May 19, 2015

Copy link
Copy Markdown
Owner

I'm not sure I like the dynamic variable idea because I think it's bad API. It's hard to document. Instead, I think that f should not require real paths whenever possible. It's better for performance also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants