Skip to content

Resque::Failure::Multiple calls save to all backends even if some backends fail#1631

Open
labocho wants to merge 2 commits into
resque:masterfrom
labocho:failure-multiple-always-calls-all-backends
Open

Resque::Failure::Multiple calls save to all backends even if some backends fail#1631
labocho wants to merge 2 commits into
resque:masterfrom
labocho:failure-multiple-always-calls-all-backends

Conversation

@labocho

@labocho labocho commented May 29, 2018

Copy link
Copy Markdown
Contributor

When some failure backend raise error during Resque::Failure::Multiple#save, the rest backends' save are never called.

class BrokenBackend < Resque::Failure::Base
  def save
    raise "Broken"
  end
end

Resque::Failure::Multiple.classes = [BrokenBackend, Resque::Failure::Redis]
Resque::Failure.backend = Resque::Failure::Multiple

# When a job fails, Resque::Failure::Redis#save is never called.

I want to call all backends' save for redundancy. I wrote patch to call all backends and wrap original error(s).

@matthewhively

matthewhively commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

This would be cool if this could be fixed up and merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labocho @matthewhively