Skip to content

feat(el): greek calendar & locale#459

Draft
ciesiolka wants to merge 22 commits into
romcal:devfrom
ciesiolka:greek-locale
Draft

feat(el): greek calendar & locale#459
ciesiolka wants to merge 22 commits into
romcal:devfrom
ciesiolka:greek-locale

Conversation

@ciesiolka

@ciesiolka ciesiolka commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

This commit contains:

  • translation of saint names as appear in Roman Missal in Greek language (2006)
  • celebrations from proper calendars of Greek Dioceses of Athens, Syros and Tinos (all from 2013)
  • saints mentioned in those calendars were added to martyrology.ts, except for:
    • dedications of own churches
    • timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops - variant of existing timothy_of_ephesus_and_titus_of_crete_bishops
    • lydia_of_philippi_first_european_christian - variant of lydia_of_philippi
    • zechariah_and_elizabeth_parents_of_john_the_baptist
    • twelve_apostles

Only some of the inserted saints were translated to Latin. To be fixed in a separate PR.

Names of some of saints inserted to the General Calendar after 2006 were added. If found, please report missing ones.

Important notice, not directly related to the commit: The Easter in Greece is celebrated according to Julian calendar, in the same date as in Orthodox Church. It means the Ash wednesday, Palm Sunday, Pentecost, Corpus Christi, etc. are shifted. I don't know if romcal supports that.

@tukusejssirs

Copy link
Copy Markdown
Member

Hey, @ciesiolka, for awesome contribition! 🙏

I’ll try and review the PR today, however, it’d be awesome if you could provide us the source (-s) (just take some pictures of the selected pages + front cover, title case and title case verso, even privately if you don’t want to publish it to everyone). Thanks in advance! 🙏

@ciesiolka

Copy link
Copy Markdown
Contributor Author

Hey, @ciesiolka, for awesome contribition! 🙏

I’ll try and review the PR today, however, it’d be awesome if you could provide us the source (-s) (just take some pictures of the selected pages + front cover, title case and title case verso, even privately if you don’t want to publish it to everyone). Thanks in advance! 🙏

Can you share with me a direct contact to you? Are you using like Discord? If not, e-mail would be fine.

@tukusejssirs

Copy link
Copy Markdown
Member

Can you share with me a direct contact to you? Are you using like Discord? If not, e-mail would be fine.

I prefer using email, but use Telegram or Diacord if you wish. See my updated profile.

Thanks! 🙏

@emagnier

emagnier commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

Thank again @ciesiolka for this great contribution!!

Important notice, not directly related to the commit: The Easter in Greece is celebrated according to Julian calendar, in the same date as in Orthodox Church. It means the Ash wednesday, Palm Sunday, Pentecost, Corpus Christi, etc. are shifted. I don't know if romcal supports that.

Currently, Romcal only support Easter calculation within a Gregorian calendar. But calculating Easter according to Julian calendar is definitively something that we can add to Romcal!

Edit: a PR is open here #460 to support the Julian Easter date, and so Julian calendar (where all liturgical dates are calculated from the date of Easter).

@tukusejssirs

Copy link
Copy Markdown
Member

@ciesiolka, @emagnier, I have started the review of this PR, but it has some issues that needs to be fixed before merging, therefore I have just converted it to a draft PR.

I want to go through all changes from all points of view (martyrology.ts, celebrations, localisation, grammar) before I publish the required changes. I hope to do so today.

While there are some big issues, the PR itslef is done very well. I consider the main issue the missing contribution docs, which I wanted to create long time ago (with @emagnier’s approval), therefore this is my fault.

tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Oct 1, 2023

@tukusejssirs tukusejssirs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciesiolka, my notes regarding this PR:

  • According to Wikipedia, there are the following dioceses in Greece (correct me if I’m wrong; cf catholic-hierarchy.org):
    • list:
      • Archdiocese of Athens;
      • Archdiocese of Rhodos (or Rhodes?);
      • Archdiocese of Corfù, Zante and Cefalonia (or Corfu?);
      • Archdiocese of Naxos, Andros, Tinos and Mykonos;
      • Diocese of Chios (or Scio?);
      • Diocese of Crete;
      • Diocese of Santorini (or Thira?);
      • Diocese of Syros and Milos;
      • Apostolic Vicariate of Thessaloniki;
    • notes:
      • You could add the missing diocesan calendars if you want, possibly in a separate PR.
      • There is no Diocese of Athens, as it isi Archdiocese of Athens.
      • As I understand it (based on the sources linked above), Dioceses Syros and Tinos are merged into Diocese of Syros and Milos and Archdiocese of Naxos, Andros, Tinos and Mykonos. That said, it might be that each of these (sub-) dioceses (which, as I understand it, were merged at some time) still has some celebrations that are celebrated on their territory only (and on the territory of the entire, merged diocese).

The TODO list is an unordered list of tasks which need to be done, either in this PR or in a follow-up PRs. I will mark them as completed, as I go through the list. Some of the change requests and comments are being added to my fork of the greek-locale branch.

TODO
  • add code comments after each l10n line with the source of the string (e.g. src: mr_el_2006_ed3 or based on: mr_el_2006_ed3);
  • verify additions to martyrology.ts;
  • consider adding the following celebrations:
    • dedications of own churches;
    • timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops - variant of existing timothy_of_ephesus_and_titus_of_crete_bishops:
      • consider replacing the current key name (and possibly key values in certain locales) to the new key;
    • lydia_of_philippi_first_european_christian - variant of lydia_of_philippi;
    • zechariah_and_elizabeth_parents_of_john_the_baptist;
    • twelve_apostles;
  • localise all added celebrations to all locales (this might be fixed in a separate PR);
  • verify if all celebrations of the Greek Proper (based on the calendar found in mr_el_2006_ed3) are correctly defined in .names in el.ts (pay heed to potential celebration transfers or removals in comparison with the GRC):
    • l10n:
      • January;
      • February;
      • March;
      • April;
      • May;
      • June;
      • July;
      • August;
      • September;
      • October;
      • November;
      • December;
      • other pages shared with us;
      • names.dedication_of_consecrated_churches: find the page number in mr_el_2006_ed3;
    • celebration metadata (date, rank, transfer, titles):
      • January;
      • February;
      • March;
      • April;
      • May;
      • June;
      • July;
      • August;
      • September;
      • October;
      • November;
      • December;
      • other pages shared with us;
  • sort the items in martyrology.ts by key name;
  • verify existing l10n key values to el;
  • verify l10n keys in .seasons;
  • verify l10n keys in .ranks;
  • verify l10n keys in .cycles;
  • verify l10n keys in .weekdays;
  • verify l10n keys in .months;
  • verify l10n keys in .ordinals;
  • verify l10n keys in .colors;
  • spell-check l10n keys in .names;
  • spell-check l10n keys in other parts of el.ts files (except for .names);
  • martyrology.ts additions verification:
    • agapitus_of_palestrina_martyr;
    • christopher_of_anatolia_martyr:
      • is he not the same as christopher_of_palestine_martyr? if so, should we rename the old key to the new one?
    • cyriacus_martyr:
      • consider changing the name to Cyriac;
      • add surname:
        • what should it be?
        • he was buried at the seventh milestone of the Via OstiensisSaint Cyriacus of the Via Ostiensis;
        • the Wikipedia article mentions him once as Saint Cyriacus at the Baths (of Diocletian)Saint Cyriacus of the Baths (of Diocletian);
        • at another place, the Wikipedia article says there is a chuched titled as Church of Saint Cyriacus in the Baths of DiocletianSaint Cyriacus at the Baths of Diocletian (la: Sanctus Ciriacus in Thermis Diocletiani; it: S. Ciriaco alle Terme di Diocleziano);
      • if he really was a deacon (or if he is really venerated/celebrated as such), therefore change his name to cyriacus_${surname}_deacon; otherwise keep the martyr title in the key name;
    • emilie_de_vialar_virgin:
      • add this to martyrology.ts, as it is missing from it;
      • rename her to emily in English and thus the key name;
      • consider changing the key name to include Anne Marguerite Adelaide Emily de Vialar;
    • lawrence_justinian:
      • add bishop title to the key name;
    • mammes_of_caesarea_martyr:
      • add approx to .dateOfDeath;
    • marcellinus_of_ancona_bishop:
      • add approx to .dateOfDeath;
    • mary_mother_of_hope:
      • consider using Our Lady in en instead of Blessed Virgin Mary;
    • miltiades_pope;
    • our_lady_of_angels;
    • our_lady_of_faneromeni:
      • rename to our_lady_of_lefkada;
    • pelagia_the_penitent_virgin:
      • if she is St Pelagia the Penitent/Harlot (AKA St Pelagia of Antioch), she was not a virgin;
      • she could be St Pelagia the Virgin (AKA St Pelagia of Antioch), but then she is not St Pelagia the Penitent;
    • romanus_martyr:
      • add surname: Ostiarius;
    • thecla_of_iconium_virgin:
      • add .dateOfDeath: 1st century AD;
    • theodore_stratelates;
    • timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops:
      • timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops: 'Saint Titus, the first Bishop of Crete, Saint Timothy, Bishops',;
      • remove this key in favour of timothy_of_ephesus_and_titus_of_crete_bishops, as it is the same celebration;
      • prefer the old key, as in English, it is used like that and no the First Bishop of ${dioceseName} is used;
  • additions l10n verification (incl surnames and a single/main title in key names):
    • agapitus_of_palestrina_martyr (src):
      • agapitus_of_palestrina_martyr: 'Saint Agapitus, Martyr';
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
      • consider adding the surname to the key values and to .name in martyrology.ts;
    • christopher_of_anatolia_martyr (src):
      • christopher_of_anatolia_martyr: 'Saint Christopher, Martyr',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • cyriacus_martyr (src):
      • cyriacus_martyr: 'Saint Cyriacus, Martyr',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • dedication_of_the_basilica_of_our_lady_of_the_snows_tinos_grece:
      • dedication_of_the_basilica_of_our_lady_of_the_snows_tinos_grece: 'The Dedication of the Basilica of Our Lady of the Snows in Tinos, Grece', // aka. Salus Populi Romani;
      • fix typo: GreceGreece;
      • consider adding this to martyrology.ts;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • dedication_of_the_cathedral_of_saint_dionysius_athens:
      • dedication_of_the_cathedral_of_saint_dionysius_athens: 'The Dedication of the Basilica of Saint Dionysius in Athens, Greece',;
      • consider adding this to martyrology.ts;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • emilie_de_vialar_virgin:
      • emilie_de_vialar_virgin: 'Saint Emily de Vialar',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la: S. Æmilia de Vialar, virginis;
      • pl;
      • pt-br;
      • sk;
    • lawrence_justinian (src):
      • lawrence_justinian: 'Saint Lawrence Justinian, bishop',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • lydia_of_philippi_first_european_christian:
      • lydia_of_philippi_first_european_christian: 'Saint Lydia of Philippi, the first Christian of Europe',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • mammes_of_caesarea_martyr (src):
      • add missing title to en l10n value;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • marcellinus_of_ancona_bishop (src);
    • martha_of_bethany:
      • martha_of_bethany: 'Saint Martha',;
      • check how is this key actually used, as it was updated by Pope Francis to include St Lazarus and St Mary;
      • if it is actually used, I presume it is used with a patronage or titular title;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • mary_mother_of_hope (no source for en translation):
      • mary_mother_of_hope: 'Blessed Virgin Mary, Mother of Hope',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • miltiades_pope (src):
      • miltiades_pope: 'Saint Miltiades, Pope',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • our_lady_of_angels (src):
      • check where is this title of Our Lady celebrated in Greece and whether it is linked to the monastery in Croatia;
      • our_lady_of_angels: 'Our Lady of Angels',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • our_lady_of_faneromeni (no source for en translation; rename to our_lady_of_lefkada):
      • our_lady_of_faneromeni: 'Our Lady of Faneromeni',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la: B. Mariæ Virginis de Faneromeni;
      • pl;
      • pt-br;
      • sk;
    • pelagia_the_penitent_virgin (src):
      • pelagia_the_penitent_virgin: 'Saint Pelagia the Penitent',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • romanus_martyr (src):
      • romanus_martyr: 'Saint Romanus, Martyr',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • thecla_of_iconium_virgin (src):
      • thecla_of_iconium_virgin: 'Saint Thecla of Iconium, Virgin and Martyr',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • theodore_stratelates (src):
      • theodore_stratelates: 'Saint Theodore Stratelates, Martyr',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • twelve_apostles:
      • twelve_apostles: 'The Holy Twelve Apostles',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • ursula_of_cologne_virgin:
      • ursula_of_cologne_virgin: 'Saint Ursula, Virgin and Martyr',;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
    • zechariah_and_elizabeth_parents_of_john_the_baptist:
      • zechariah_and_elizabeth_parents_of_john_the_baptist: 'Saints Zechariah and Elizabeth, parents of John the Baptist',;
      • capitalise Parents title;
      • add Parents title to Titles enum;
      • cs;
      • es;
      • fr;
      • hu;
      • it;
      • la;
      • pl;
      • pt-br;
      • sk;
  • fix and remove TODO items;

Comment thread lib/particular-calendars/costa-rica.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
Comment thread lib/locales/el.ts Outdated
@emagnier

emagnier commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

Thank you both for this fabulous job! Both for this extensive localization and information addition work, as well as for the meticulous PR review 💪 🙏

@tukusejssirs, your notes and to-do list are very comprehensive and well done, but I also find them a bit intimidating 😨. Let's be careful not to scare off or discourage contributions 😄. However, this highlights the need to create a much more comprehensive contribution guide that we can refer to, with different levels of possible contributions.
And in general (as I've mentioned elsewhere), I prefer that we don't make PRs too large and take it step by step, depending on everyone's time and availability.

In case there are localizations that we're unsure about, but can't verify quickly, I suggest including these comments in the localization file (as code comments). While it's not ideal, at least it won't block the PR (while keeping a record of points to check).

We should also think and find a more sustainable way to specify sources for each added piece of information (to be discussed and addressed in a separate topic).

@emagnier emagnier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding a few additional comments. In addition to the specific points I mentioned, I've noticed that these items (locale & martyrology items) do not have corresponding calendar definitions (likely to be added in greece.ts):

  • agapitus_of_palestrina_martyr
  • christopher_of_anatolia_martyr
  • cyriacus_martyr
  • lawrence_justinian
  • mammes_of_caesarea_martyr
  • marcellinus_of_ancona_bishop
  • mary_mother_of_hope
  • miltiades_pope
  • pelagia_the_penitent_virgin
  • romanus_martyr
  • thecla_of_iconium_virgin
  • theodore_stratelates

Comment thread lib/locales/en.ts Outdated
luigi_orione_priest: 'Saint Luigi Orione, Priest',
luke_evangelist: 'Saint Luke, Evangelist',
lydia_of_philippi: 'Saint Lydia of Philippi',
lydia_of_philippi_first_european_christian: 'Saint Lydia of Philippi, the first Christian of Europe',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that in lib/particular-calendars/greece.ts, there is still no references for lydia_of_philippi_first_european_christian.

If you want to apply a different locale (other than the default one lydia_of_philippi), only and specifically for this calendar, you should modify the lydia_of_philippi calendar definition in greece.ts to:

lydia_of_philippi: {
  precedence: Precedences.ProperMemorial_11b,
  customLocaleId: 'lydia_of_philippi_first_european_christian',
  dateDef: { month: 8, date: 3 },
},

@tukusejssirs tukusejssirs May 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, lydia_of_philippi is inscribed in the Greek National Proper only (no other calendar in romcal has that celebration inscribed).

Therefore, I think it it safe to replace lydia_of_philippi with lydia_of_philippi_the_first_christian_of_europe (updated to what I believe is a better translation of the title) in every locale and greek.ts. Moreover, it would be nice to add FIRST_CHRISTIAN_OF_EUROPE (or FIRST_CHRISTIAN with place set to EUROPE) to the list of patronage titles.

@tukusejssirs tukusejssirs May 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lydia_of_philippi_first_european_christian should be renamed to lydia_of_philippi_the_first_christian_of_europe.

The question is, however, whether we should also rename it in martyrology.ts or only add martyrology: ['lydia_of_philippi'] in the celebration definition in greece.ts. We should also consider the value of .name in there (that depends on whether we add the new patronage title, see the previous comment of mine). 🤔

I am about to rename it everywhere (incl martyrology.ts and .name will not be changed) to lydia_of_philippi_the_first_christian_of_europe.

Comment thread lib/locales/en.ts
Comment on lines 967 to +1002
timothy_of_ephesus_and_titus_of_crete_bishops: 'Saints Timothy and Titus, Bishops',
timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops:
'Saint Titus, the first Bishop of Crete, Saint Timothy, Bishops',

@emagnier emagnier Oct 6, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for lydia_of_philippi_first_european_christian.

The locale timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops is not referenced elsewhere other than in the locale files. As the corresponding definition is already defined in the proper-of-saints.ts, you should add a calendar definition in greece.ts that extends its definition, and specify the custom locale entry only in this particular calendar:

// To be added in greece.ts
timothy_of_ephesus_and_titus_of_crete_bishops: {
   customLocaleId: 'timothy_of_ephesus_and_titus_the_first_bishop_of_crete_bishops',
},

Comment thread lib/locales/en.ts
translation_of_the_relics_of_odile_of_alsace_abbess: 'Translation of the Relics of Saint Odile',
translation_of_the_relics_of_saint_stephen_of_hungary: 'Translation of the Relics of Saint Stephen of Hungary',
turibius_of_mogrovejo_bishop: 'Saint Turibius of Mogrovejo, Bishop',
twelve_apostles: 'The Holy Twelve Apostles',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one does not have a matching calendar definition. Is the calendar definition missing? Or is it a locale that should be applied to an existing element but only for greece.ts?

Comment thread lib/locales/en.ts
yolanda_of_poland_religious: 'Blessed Yolanda, Religious',
zdenka_cecilia_schelingova_virgin: 'Blessed Zdenka Cecilia Schelingová, Virgin and Martyr',
zdislava_of_lemberk: 'Saint Zdislava',
zechariah_and_elizabeth_parents_of_john_the_baptist: 'Saints Zechariah and Elizabeth, parents of John the Baptist',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as twelve_apostles, there is actually no matching calendar definitions.

Comment thread lib/locales/en.ts
Comment on lines +349 to +357
dedication_of_the_basilica_of_our_lady_of_the_snows_tinos_grece:
'The Dedication of the Basilica of Our Lady of the Snows in Tinos, Grece', // aka. Salus Populi Romani

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calendar definition for this item is missing, you should add it to greece.ts.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to resolve some of these, but I can't find references to our lady of snows in tinos yet.

there's definitely an "our lady of tinos"...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be defined in greece.tinos.ts. It can be sourced from this file from p449 (5 August/ΑΥΓΟΥΣΤΟΣ).

Comment thread lib/locales/en.ts
Comment on lines +358 to +366
dedication_of_the_cathedral_of_saint_dionysius_athens:
'The Dedication of the Basilica of Saint Dionysius in Athens, Greece',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calendar definition for this item is missing, you should add it to greece.ts.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, no all celebrations are defined in greece.ts. That said, I believe that this celebration will be defined in greece.athens.ts () instead. Moreover in el.ts, the value might not be correct (see this Greek Wikipedia article).

Anyway, I have quickly gone through the files shared with us, but I could not find this celebrated in there. I might have missed something though. That said, the celebration should exist anyway. 😉

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it can be found in this file on p326.

@emagnier

emagnier commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

Names of some of saints inserted to the General Calendar after 2006 were added. If found, please report missing ones.

@ciesiolka, I ran the script I developed here #461 on your PR. Here is what it flagged as missing:

 WARN  Missing localized 'el' items for the Proper of Time and the General Roman Calendar:
       names:
       - ash_wednesday
       - thursday_of_the_lords_supper
       - friday_of_the_passion_of_the_lord
       - holy_saturday
       - ascension_of_the_lord
       - sunday_of_the_word_of_god
       - john_of_avila_priest
       - paul_vi_pope
       - henry_ii_emperor
       - wenceslaus_i_of_bohemia_martyr
       - hedwig_of_silesia_religious
       - dedication_of_consecrated_churches
       - columban_of_luxeuil_abbot
       - lucy_of_syracuse_virgin

@emagnier emagnier added concept: calendar definitions For issues about existing or new definitions of liturgical days / calendars concept: localization Anything related to localisation, i18n, locale keys... labels Oct 6, 2023
@emagnier emagnier marked this pull request as ready for review October 6, 2023 12:19
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Oct 20, 2023
I have verified February celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Oct 29, 2023
I have verified March and April celebration names using `mr_el_2006_ed3`. I have also added chapter and section heading names and page number to the sources.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Jan 29, 2024
I have verified the May celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 1, 2024
I have verified the June celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 3, 2024
I have verified the July celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 4, 2024
I have verified the August celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 4, 2024
I have verified the September celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 10, 2024
I have verified the October celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 10, 2024
I have verified the November and December celebration names using `mr_el_2006_ed3`.
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 10, 2024
@tukusejssirs

tukusejssirs commented Feb 10, 2024

Copy link
Copy Markdown
Member

@ciesiolka, I made some updates to this PR in my fork of your greek-locale branch, however, it seems like I have no sufficient rights on romcal repository to push my changes to your repository. Could you force-pull my changes please? Thanks in advance! 🙏

I have verified (and fixed all typos) all the keys from the GRC (Γενικό Ρωμαϊκό εορτολόγιο) in mr_el_2006_ed3 for Greece-wide celebrations (i.e. no diocesan celebrations were verified yet), added source comments to all keys I have verified, rebased the branch on top of dev.

After you (or @emagnier) force-push the changes to your branch, I want to add some review comments on some (potential) issues (I don’t want to talk about them outside of the code context).


@emagnier, could you give me push access to romcal repository please? I wanted to push my changes into @ciesiolka’s repository, however, although he allowed us to push to his branch ([x] Maintainers are allowed to edit this pull request.), it seems like I can’t do it without the ability to push to romcal repository, see the docs. Thanks! 🙏


I hope you both are doing well! 🙏

tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 11, 2024
tukusejssirs added a commit to tukusejssirs/romcal that referenced this pull request Feb 11, 2024
Changes:

- added source references based on the additional pages from `mr_el_2006_ed3` shared with me;
- added the following keys based on various sources:
  - `ascension_of_the_lord`;
  - `ash_wednesday`;
  - `divine_mercy_sunday`;
  - `easter_sunday`;
  - `friday_of_the_passion_of_the_lord`;
  - `holy_saturday`;
  - `john_of_avila_priest`;
  - `paul_vi_pope`;
  - `sunday_of_the_word_of_god`;
  - `thursday_of_the_lords_supper`;
- changed the value of the following keys based on `mr_el_2006_ed3`:
  - `cycles.proper_of_time`;
  - `seasons.paschal_triduum.season`;
- replaced the following key names, as the old key names were errors:
  - `columba_of_iona_abbot` → `columban_of_luxeuil_abbot`;
  - `eric_ix_of_sweden_martyr` → `henry_ii_emperor`;
  - `hedwig_of_poland` → `hedwig_of_silesia_religious`;
- fixed a typo: `περίοδου` → `περιόδου`.

Review of romcal#459
@tukusejssirs

Copy link
Copy Markdown
Member

@ciesiolka, I have just pushed some new changes to my fork, see the changelog bellow.

fix(el): fix some celebration names

Changes:

  • added source references based on the additional pages from mr_el_2006_ed3 shared with me;
  • added the following keys based on various sources:
    • ascension_of_the_lord;
    • ash_wednesday;
    • divine_mercy_sunday;
    • easter_sunday;
    • friday_of_the_passion_of_the_lord;
    • holy_saturday;
    • john_of_avila_priest;
    • paul_vi_pope;
    • sunday_of_the_word_of_god;
    • thursday_of_the_lords_supper;
  • changed the value of the following keys based on mr_el_2006_ed3:
    • cycles.proper_of_time;
    • seasons.paschal_triduum.season;
  • replaced the following key names, as the old key names were errors:
    • columba_of_iona_abbotcolumban_of_luxeuil_abbot;
    • eric_ix_of_sweden_martyrhenry_ii_emperor;
    • hedwig_of_polandhedwig_of_silesia_religious;
  • fixed a typo: περίοδουπεριόδου.

tukusejssirs added a commit to ciesiolka/romcal that referenced this pull request Aug 24, 2024
tukusejssirs added a commit to ciesiolka/romcal that referenced this pull request Aug 24, 2024
Changes:

- added source references based on the additional pages from `mr_el_2006_ed3` shared with me;
- added the following keys based on various sources:
  - `ascension_of_the_lord`;
  - `ash_wednesday`;
  - `divine_mercy_sunday`;
  - `easter_sunday`;
  - `friday_of_the_passion_of_the_lord`;
  - `holy_saturday`;
  - `john_of_avila_priest`;
  - `paul_vi_pope`;
  - `sunday_of_the_word_of_god`;
  - `thursday_of_the_lords_supper`;
- changed the value of the following keys based on `mr_el_2006_ed3`:
  - `cycles.proper_of_time`;
  - `seasons.paschal_triduum.season`;
- replaced the following key names, as the old key names were errors:
  - `columba_of_iona_abbot` → `columban_of_luxeuil_abbot`;
  - `eric_ix_of_sweden_martyr` → `henry_ii_emperor`;
  - `hedwig_of_poland` → `hedwig_of_silesia_religious`;
- fixed a typo: `περίοδου` → `περιόδου`.

Review of romcal#459
emagnier pushed a commit to ciesiolka/romcal that referenced this pull request Oct 9, 2024
emagnier pushed a commit to ciesiolka/romcal that referenced this pull request Oct 9, 2024
Changes:

- added source references based on the additional pages from `mr_el_2006_ed3` shared with me;
- added the following keys based on various sources:
  - `ascension_of_the_lord`;
  - `ash_wednesday`;
  - `divine_mercy_sunday`;
  - `easter_sunday`;
  - `friday_of_the_passion_of_the_lord`;
  - `holy_saturday`;
  - `john_of_avila_priest`;
  - `paul_vi_pope`;
  - `sunday_of_the_word_of_god`;
  - `thursday_of_the_lords_supper`;
- changed the value of the following keys based on `mr_el_2006_ed3`:
  - `cycles.proper_of_time`;
  - `seasons.paschal_triduum.season`;
- replaced the following key names, as the old key names were errors:
  - `columba_of_iona_abbot` → `columban_of_luxeuil_abbot`;
  - `eric_ix_of_sweden_martyr` → `henry_ii_emperor`;
  - `hedwig_of_poland` → `hedwig_of_silesia_religious`;
- fixed a typo: `περίοδου` → `περιόδου`.

Review of romcal#459
ciesiolka and others added 22 commits October 11, 2024 09:29
Changes:

- added source references based on the additional pages from `mr_el_2006_ed3` shared with me;
- added the following keys based on various sources:
  - `ascension_of_the_lord`;
  - `ash_wednesday`;
  - `divine_mercy_sunday`;
  - `easter_sunday`;
  - `friday_of_the_passion_of_the_lord`;
  - `holy_saturday`;
  - `john_of_avila_priest`;
  - `paul_vi_pope`;
  - `sunday_of_the_word_of_god`;
  - `thursday_of_the_lords_supper`;
- changed the value of the following keys based on `mr_el_2006_ed3`:
  - `cycles.proper_of_time`;
  - `seasons.paschal_triduum.season`;
- replaced the following key names, as the old key names were errors:
  - `columba_of_iona_abbot` → `columban_of_luxeuil_abbot`;
  - `eric_ix_of_sweden_martyr` → `henry_ii_emperor`;
  - `hedwig_of_poland` → `hedwig_of_silesia_religious`;
- fixed a typo: `περίοδου` → `περιόδου`.

Review of romcal#459
For some reason, I have not pulled it during the rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

concept: calendar definitions For issues about existing or new definitions of liturgical days / calendars concept: localization Anything related to localisation, i18n, locale keys...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants