Skip to content

Bump sriov charts up1.6.0#247

Merged
antaloala merged 2 commits into
suse-edge:mainfrom
antaloala:bump-sriov-charts-up1.6.0
Mar 31, 2026
Merged

Bump sriov charts up1.6.0#247
antaloala merged 2 commits into
suse-edge:mainfrom
antaloala:bump-sriov-charts-up1.6.0

Conversation

@antaloala

Copy link
Copy Markdown
Contributor

No description provided.

@antaloala antaloala requested review from diconico07 and hardys March 31, 2026 09:25

@diconico07 diconico07 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first quick pass, didn't looked closely yet, so just a comment for now

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this, you are embedding the whole chart as an overlay, so if we go that path, you probably want to also remove the packages/sriov-nfd directory as a whole

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously it was handled via ‎packages/sriov-network-operator/generated-changes/dependencies/sriov-nfd/dependency.yaml‎ - is there a reason to prefer this approach or can we just restore the dependency?

@antaloala antaloala Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also thought about removing that existing sriov-nfd package (as you say, in the way I am managing it, I did not use that package at all) ... but note we have pending to decouple these two charts and so making the sriov-nfd to be packaged and deployed out from the sriov-network-operator; NFD is not really "limited" to sriov, it is actually being used by other use cases; e.g. AI guys using it for NVDIA GPU discovery (handled as another embedded suchart in another AI top chat); we already started to briefly discuss the possibility to try to keep a single independent NFD chart/package valid for all use-case ... so I then preferred not to remove it (not yet)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-created the 2 commits after adding the missing dependencies settings to the first commit; now it should be ok the way to use the (also updated) sriov-nfd package from the sriov-network-operator package so the first one becomes a subchart into the chart generated from the second

@antaloala antaloala requested a review from diconico07 March 31, 2026 10:45
@antaloala antaloala force-pushed the bump-sriov-charts-up1.6.0 branch from 11c7c29 to 3ad34ce Compare March 31, 2026 14:59

@diconico07 diconico07 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't do a diff of the chart with the Factory one to ensure everything is alright on this side though.

@antaloala

antaloala commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

This is version 1.6.4+up1.6.0 (for both the sriov-network-operator and the sriov-crd new Helm chart versions being proposed)

Here below the result after deploying the two new sriov Helm chart versions (for sriov-crd and sriov-network-operator Helm charts) available in my local repo:

$ helm ls -n sriov-system

NAME                  	NAMESPACE   	REVISION	UPDATED                                 	STATUS  	CHART                               	APP VERSION
sriov-crd             	sriov-system	1       	2026-03-31 17:11:55.739978408 +0200 CEST	deployed	sriov-crd-1.6.4+up1.6.0             	v1.6.0     
sriov-network-operator	sriov-system	1       	2026-03-31 17:12:46.724409379 +0200 CEST	deployed	sriov-network-operator-1.6.4+up1.6.0	v1.6.0 

@antaloala antaloala merged commit 6027bec into suse-edge:main Mar 31, 2026
1 check passed
@antaloala antaloala deleted the bump-sriov-charts-up1.6.0 branch March 31, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants