Bump sriov charts up1.6.0#247
Conversation
diconico07
left a comment
There was a problem hiding this comment.
Did a first quick pass, didn't looked closely yet, so just a comment for now
There was a problem hiding this comment.
Doing this, you are embedding the whole chart as an overlay, so if we go that path, you probably want to also remove the packages/sriov-nfd directory as a whole
There was a problem hiding this comment.
Previously it was handled via packages/sriov-network-operator/generated-changes/dependencies/sriov-nfd/dependency.yaml - is there a reason to prefer this approach or can we just restore the dependency?
There was a problem hiding this comment.
Yes, I also thought about removing that existing sriov-nfd package (as you say, in the way I am managing it, I did not use that package at all) ... but note we have pending to decouple these two charts and so making the sriov-nfd to be packaged and deployed out from the sriov-network-operator; NFD is not really "limited" to sriov, it is actually being used by other use cases; e.g. AI guys using it for NVDIA GPU discovery (handled as another embedded suchart in another AI top chat); we already started to briefly discuss the possibility to try to keep a single independent NFD chart/package valid for all use-case ... so I then preferred not to remove it (not yet)
There was a problem hiding this comment.
I have re-created the 2 commits after adding the missing dependencies settings to the first commit; now it should be ok the way to use the (also updated) sriov-nfd package from the sriov-network-operator package so the first one becomes a subchart into the chart generated from the second
11c7c29 to
3ad34ce
Compare
diconico07
left a comment
There was a problem hiding this comment.
LGTM, didn't do a diff of the chart with the Factory one to ensure everything is alright on this side though.
|
This is version 1.6.4+up1.6.0 (for both the sriov-network-operator and the sriov-crd new Helm chart versions being proposed) Here below the result after deploying the two new sriov Helm chart versions (for sriov-crd and sriov-network-operator Helm charts) available in my local repo: |
No description provided.