Expose document_id and file_path in retriever output#286
Open
rachedkko wants to merge 2 commits into
Open
Conversation
Collaborator
|
Looks good to me @rachedkko, just that the tests have to be adapted, as well as the API documentation at docs/source/developer_documentation/retriever_api_specs.yaml |
fabnemEPFL
requested changes
May 8, 2026
fabnemEPFL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me @rachedkko, just that the tests have to be adapted, as well as the API documentation at docs/source/developer_documentation/retriever_api_specs.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Milvus collection already stores
document_idandfile_path, but the retriever's defaultoutput_fieldsdidn't include them.Changes
Retriever.retrieve/batch_retrievedefaultoutput_fieldsnow includedocument_idandfile_pathPOST /v1/retrieveexposes them asdocumentIdandfilePathGET /v1/chunks/{fileId}/{chunkId}does the sameMotivation
Agentic pipelines (AMMORE) need to cite the source document a chunk came from.