[LiveComponent] added basic error rendering of fetch failure and added request:error hook#3535
Open
FabianKoehnen wants to merge 2 commits into
Open
[LiveComponent] added basic error rendering of fetch failure and added request:error hook#3535FabianKoehnen wants to merge 2 commits into
FabianKoehnen wants to merge 2 commits into
Conversation
…d request:error hook
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, as described in the Issue currently there is problem that if an request fails the js freezes.
I looked into it and the issue is that there is currently no fetch.catch() to handle errors with the fetch itself.
As far as can see currently the code only handles faulty responses.
This Pr add:
The request:error hook works mostly like response:error, so to prevent the modal from showing up you can do this:
Steps to reproduce the Error