Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

test(web): add test for circular reference fix in useChangeSets#8266

Merged
aaron-dernley merged 1 commit into
mainfrom
fix/bug-1211-add-usechangeset-ctx-nav-test
Jan 13, 2026
Merged

test(web): add test for circular reference fix in useChangeSets#8266
aaron-dernley merged 1 commit into
mainfrom
fix/bug-1211-add-usechangeset-ctx-nav-test

Conversation

@aaron-dernley

@aaron-dernley aaron-dernley commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

This PR:

Addresses action from INC https://systeminit.slack.com/archives/C0A7W24MSKE

How was it tested?

  • pnpm vitest run src/newhotness/Workspace.test.ts passes (2 tests)
  • Validated test catches the bug: reverted fix → test fails with CIRCULAR REFERENCE DETECTED, restored fix → test passes

When the fix is reverted, the test fails with a clear explanation. When the fix is applied, the test passes.

Does it require a docs change?

  • No
  • Yes, and this PR includes it
  • Yes, and this PR does not include it (reasoning below)

In short: 🔗

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the A-web label Jan 13, 2026
@aaron-dernley aaron-dernley force-pushed the fix/bug-1211-add-usechangeset-ctx-nav-test branch 5 times, most recently from db66b7a to f9b3278 Compare January 13, 2026 21:23
@aaron-dernley aaron-dernley force-pushed the fix/bug-1211-add-usechangeset-ctx-nav-test branch from f9b3278 to d166194 Compare January 13, 2026 21:43
@aaron-dernley aaron-dernley marked this pull request as ready for review January 13, 2026 21:53
@aaron-dernley aaron-dernley added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit a46575a Jan 13, 2026
10 checks passed
@aaron-dernley aaron-dernley deleted the fix/bug-1211-add-usechangeset-ctx-nav-test branch January 13, 2026 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants