Add dedicated network configs#201
Merged
Merged
Conversation
Collaborator
Author
|
@showuon Did some ClusterMirrorConfig refactoring to reuse existing constants where appropriate and also updated the KIP to list only new properties. STs are good: ================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.14.0
session_id: 2026-06-16--001
run time: 20 minutes 0.032 seconds
tests run: 24
passed: 24
flaky: 0
failed: 0
ignored: 0
================================================================================ |
Mirror fetcher threads (MirrorFetcherThread + MirrorSourceSender) previously shared all fetch and socket configs with internal replication (ReplicaFetcherThread). This meant cross-cluster mirroring could not be tuned independently. For example, a mirror fetching from a remote datacenter with higher latency could not use a longer socket timeout without also affecting intra-cluster replication. This patch adds 7 new per-mirror configs: - mirror.fetch.wait.max.ms = 1000 - mirror.fetch.backoff.ms = 1000 - mirror.fetch.min.bytes = 1 - mirror.fetch.response.max.bytes = 10485760 - mirror.fetch.max.bytes = 1048576 - mirror.socket.timeout.ms = 30000 - mirror.socket.receive.buffer.bytes = 65536 Running fetcher threads pick up new values when they are recreated (e.g., after leader change or mirror restart), not while running. Broker-level defaults can be set in server.properties but require a restart, same as the replica equivalents. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror fetcher threads (MirrorFetcherThread + MirrorSourceSender) previously shared all fetch and socket configs with internal replication (ReplicaFetcherThread). This meant cross-cluster mirroring could not be tuned independently. For example, a mirror fetching from a remote datacenter with higher latency could not use a longer socket timeout without also affecting intra-cluster replication.
This patch adds 7 new per-mirror configs:
Running fetcher threads pick up new values when they are recreated (e.g., after leader change or mirror restart), not while running. Broker-level defaults can be set in server.properties but require a restart, same as the replica equivalents.