Update hood controls for better UX in HomeAssistant and Apple Home UI#507
Draft
fholgado wants to merge 3 commits into
Draft
Update hood controls for better UX in HomeAssistant and Apple Home UI#507fholgado wants to merge 3 commits into
fholgado wants to merge 3 commits into
Conversation
535feda to
aeddb92
Compare
aeddb92 to
667ad69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I'm not a Python dev and I am very new to the HA scene. This PR is 100% made via Codex, and I've been testing this over the past 3 days. I'm opening this PR as a draft for feedback. If there's anything ridiculous here, I apologize in advance for the robots.
This PR attempts to improve the UI for controlling the fan and light entities exposed by GE vent hoods. When I initially added this to my HA instance, I found the functionality to work well but was unhappy with how the discrete fan speeds and light brightness options were exposed to Homekit via "select" entities.
Using the precedent set by how other fan integrations with discrete steps work, I asked Codex to come up with an approach to re-implement the vent hood fan as a proper "fan" entity, and did the same with the light to expose it as a brightness slider.
The PR attempts to be backwards compatible with existing installs that use the "select" entities. It will expose new, duplicate "fan" and "light" entities in addition to the "legacy" ones. We updated the readme to reflect this.
And one more small fix while I was at it, it looks like there was an issue with how my device was reporting the manufacturer and model number, and I asked Codex to attempt a fix. The issue being that my hood model is
UVC..which maps the first characterUtounknown.Thanks for working on this integration!