Skip to content

Fix #648 Cabal version depends on custom setup deps syntax#650

Merged
mpilgrem merged 1 commit into
mainfrom
fix648
Jun 7, 2026
Merged

Fix #648 Cabal version depends on custom setup deps syntax#650
mpilgrem merged 1 commit into
mainfrom
fix648

Conversation

@mpilgrem

@mpilgrem mpilgrem commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

See:

Also bumps the LTS snapshot in stack.yaml.

Not set up for immediate release if merged, because a #649 fix (trivial) may go hand-in-hand.

@sol

sol commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Not set up for immediate release if merged, because a #649 fix (trivial) may go hand-in-hand.

  1. In general I follow "release early, release often". That means every change that is a clear improvement can be released immediately.
  2. I think this change can go into a minor version, Assume at least cabal-version: 3.4 when using pkg:lib syntax #649 however will require a major version bump.

sol
sol requested changes Jun 6, 2026
View reviewed changes

@sol sol left a comment •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍🎉

Can you:

  • add a test
  • if you agree that this can go into a minor version, then bump the minor version

@mpilgrem

mpilgrem commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator Author

@sol, where should such a test be located? I had looked for similar tests (by seaching for cabal-version) but none jumped out at me.

@sol

sol commented Jun 6, 2026

Copy link
Copy Markdown
Owner

@sol, where should such a test be located? I had looked for similar tests (by seaching for cabal-version) but none jumped out at me.

Probably right after this test case:

hpack/test/EndToEndSpec.hs

Line 1291 in 5b9cddf

it "accepts dependencies" $ do

see also:

hpack/test/EndToEndSpec.hs

Line 918 in 5b9cddf

it "accepts dependencies with subcomponents" $ do

@mpilgrem
Fix #648 Cabal version depends on custom setup deps syntax
af748bb 
Also adds a test.

Also bumps LTS snapshot in stack.yaml.
@mpilgrem mpilgrem merged commit b493972 into main Jun 7, 2026
9 checks passed
@mpilgrem mpilgrem deleted the fix648 branch June 7, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sol sol sol requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpilgrem @sol