Skip to content

Refine the API documentation to point to top-level package#618

Draft
LecrisUT wants to merge 5 commits into
spglib:developfrom
LecrisUT:fix/617
Draft

Refine the API documentation to point to top-level package#618
LecrisUT wants to merge 5 commits into
spglib:developfrom
LecrisUT:fix/617

Conversation

@LecrisUT

@LecrisUT LecrisUT commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

Seems like whatever issues we had with documenting the top-level package in sphinx is gone, so we can revisit the documentation and export of all pulbic objects.

Depends-on #619
Closes #617

@codecov

codecov Bot commented Nov 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.05%. Comparing base (f1aa09c) to head (18ee13b).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #618   +/-   ##
========================================
  Coverage    74.05%   74.05%           
========================================
  Files           27       27           
  Lines         8018     8018           
  Branches      1646     1643    -3     
========================================
  Hits          5938     5938           
  Misses        1603     1603           
  Partials       477      477           
Flag Coverage Δ
c_api 69.45% <ø> (ø)
fortran_api 52.96% <ø> (ø)
python_api 67.18% <ø> (ø)
unit_tests 11.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread python/spglib/spglib.py Outdated
@LecrisUT LecrisUT marked this pull request as ready for review November 20, 2025 08:12
@LecrisUT LecrisUT force-pushed the fix/617 branch 2 times, most recently from 5e8e8c2 to 94238b5 Compare November 20, 2025 15:38
Comment thread python/spglib/__init__.py
Needed to properly document typealiases
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT LecrisUT marked this pull request as draft December 1, 2025 09:27
@LecrisUT

LecrisUT commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Moving this to draft since we are blocked by myst-parser having to catch up with sphinx. Will ping when that is resolved.

Edit: Hmm, actually I could split this PR into 2 to at least export the type-aliases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python typehints and __all__ in __init__.py

3 participants