core: lazy reload analyze stats with mvcc#7438
Open
pereman2 wants to merge 3 commits into
Open
Conversation
PThorpe92
reviewed
Jun 10, 2026
| if stats.tables.is_empty() { | ||
| return; | ||
| } | ||
| let mut with_stats = (*schema).clone(); |
Collaborator
There was a problem hiding this comment.
doing two deep clones of the schema here is gonna be hella expensive... I'm looking to see if we can get around this somehow
Collaborator
There was a problem hiding this comment.
Actually yeah let's just move the AnalyzeStats out of the Schema and then we can atomic swap them. I will push to this branch
Collaborator
|
simulator run fails on main 😢 so unfortunately unrelated to these changes |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From clanker: Under MVCC, the ANALYZE-stats loader ran before the schema it needed existed and never ran again, so the optimizer planned every query with zero statistics — and one cost-model tie later, a point-delete became a 10,000-row scan that dominated both the latency floor and the contention abort storm.
I have 0 idea about how analyze works currently but this indeed fixed problems with analyze and mvcc