Skip to content

compact: share marker gathering filter logic#8818

Open
officialasishkumar wants to merge 1 commit into
thanos-io:mainfrom
officialasishkumar:compact-shared-marker-filter
Open

compact: share marker gathering filter logic#8818
officialasishkumar wants to merge 1 commit into
thanos-io:mainfrom
officialasishkumar:compact-shared-marker-filter

Conversation

@officialasishkumar

@officialasishkumar officialasishkumar commented May 12, 2026

Copy link
Copy Markdown
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #5962.

  • Add a shared block marker-gathering helper for metadata filters that scan marker JSON files.
  • Use it from the no-compact and no-downsample marker filters while keeping their typed accessors and error wrapping intact.
  • Add focused tests for the shared helper and both component filter wrappers.

Verification

  • go test -tags slicelabels ./pkg/block ./pkg/compact ./pkg/compact/downsample -run 'TestGatherMarkedBlocks|TestGatherNoCompactionMarkFilter|TestGatherNoDownsampleMarkFilter' -count=1
  • THANOS_TEST_OBJSTORE_SKIP=GCS,S3,AZURE,SWIFT,COS,ALIYUNOSS,BOS,OCI,OBS go test -tags slicelabels ./pkg/block ./pkg/compact ./pkg/compact/downsample -count=1

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine GatherNoCompactionMarkFilter and GatherNoDownsampleMark to prevent code duplication

1 participant