lottie/expressions: support content() access by numeric index#4436
Open
tinyjin wants to merge 1 commit into
Open
lottie/expressions: support content() access by numeric index#4436tinyjin wants to merge 1 commit into
tinyjin wants to merge 1 commit into
Conversation
Binary Size Report
|
There was a problem hiding this comment.
Pull request overview
This PR extends the Lottie expressions content() accessor to support numeric indices, using the authored "ix" value when present and falling back to the object’s order within its parent’s shape list when "ix" is absent.
Changes:
- Parse and store
"ix"onLottieObjectand assign a fallback index during shape list parsing when missing. - Add
LottieGroup::contentByIdx()to resolve children by numeric index. - Update the expressions
content()binding to accept either a string (name) or numeric (index) argument.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/loaders/lottie/tvgLottieParser.cpp | Parses object "ix" and assigns a default index when missing. |
| src/loaders/lottie/tvgLottieModel.h | Adds LottieObject::ix and introduces LottieGroup::contentByIdx() lookup. |
| src/loaders/lottie/tvgLottieExpressions.cpp | Updates content() to resolve targets by either name or numeric index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The index uses the item's authored "ix", or its order in the shape list when absent. related: #4394
e6d26f4 to
dba0077
Compare
Pixel Test Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index uses the item's authored
"ix",or its order in the shape list when absent.
related: #4394
test file :
content_index.json