lottie/expressions: support marker#4439
Draft
tinyjin wants to merge 1 commit into
Draft
Conversation
Expose composition markers to expressions: - numKeys, key(index|name), nearestKey(t) related: #4394
Binary Size Report
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for accessing Lottie composition markers from the expressions runtime, aligning with the After Effects-style marker API (numKeys, key(index|name), nearestKey(t)), to address marker-driven expression workflows (ref. #4394).
Changes:
- Exposes
thisComp.markerto expressions and registers"marker"as a known magic string. - Implements marker object methods/properties:
numKeys,key(...),nearestKey(...). - Wires marker object creation into
LottieExpressions::buildComp(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
let's hold off on this until we have a practical requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose composition markers to expressions:
related: #4394
test file : sample.json