lottie/text: support perpendicular rotation in text follow path#4449
Open
tinyjin wants to merge 1 commit into
Open
lottie/text: support perpendicular rotation in text follow path#4449tinyjin wants to merge 1 commit into
tinyjin wants to merge 1 commit into
Conversation
Binary Size Report
|
There was a problem hiding this comment.
Pull request overview
Adds support for the Lottie text-follow-path “perpendicular” option by parsing the follow-path p property and applying it during glyph placement so text can rotate according to the path’s direction.
Changes:
- Parse the follow-path
pproperty from Lottie JSON into the text follow-path model. - Store the parsed perpendicular flag in the render context used during text layout.
- When enabled, rotate glyph transforms by the path angle during follow-path placement.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/loaders/lottie/tvgLottieParser.cpp | Parses follow-path p into the text follow-path structure. |
| src/loaders/lottie/tvgLottieModel.h | Adds a perpendicular property to LottieTextFollowPath. |
| src/loaders/lottie/tvgLottieBuilder.h | Tracks a perpToPath flag in RenderText context. |
| src/loaders/lottie/tvgLottieBuilder.cpp | Evaluates perpendicular per-frame and rotates glyph transforms when enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pixel Test Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing spec, perpendicular option in the text follow path.
see : https://lottiefiles.github.io/lottie-docs/text/#text-follow-path
test file : embedded_text_on_path_sample.json