fix: bind imported Codex sessions to matching machine#886
Open
dzshzx wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Findings
- No issues found.
Summary
- Review mode: initial
- Reviewed the full PR diff for Codex desktop direct import machine binding. No blocker/major/minor issues found in the added path matching, unique-online-machine selection, existing metadata preservation, or regression test coverage.
- Residual risk: I did not run the full test suite in this automation pass; relying on the PR-reported hub/Codex import tests plus static review.
Testing
- Not run (automation)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cwdis covered by exactly one online machine workspace rootmachineIdvalues and leave ambiguous/no-match imports unboundWhy
Direct Codex transcript import currently records
host,os, andpath, but notmachineId. The web sidebar groups sessions bymetadata.machineId, so imports from a connected runner can appear under the unknown machine group even when theircwdbelongs to a known workspace root.This keeps the inference conservative: only one matching online machine gets bound; ambiguous matches still stay unbound.
Tests
npx --yes bun@1.3.14 test hub/src/web/routes/codexDesktop.test.tsnpx --yes bun@1.3.14 run --cwd hub typechecknpx --yes bun@1.3.14 run --cwd hub test