Add New "Shards" Spinner#149
Open
kartikcho wants to merge 2 commits into
Open
Conversation
Author
|
I would appreciate a code review as I have a few questions to ask. I tried to begin with a full connected triangle animation but calc() wasn't giving correct size with a few decimal pixels error. The calculated border size should be 20 in this case. Also there are a few recurring attributes that could be applied to every shard child but I don't know how other than defining a new class with those attributes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been reading your css animation tutorials for the past couple days and wanted to add my own spinner to your amazing work.
This is the spinner in action:
