fix: port80 listener toggle and default site routing on HTTP#1184
Open
yannickid wants to merge 1 commit into
Open
fix: port80 listener toggle and default site routing on HTTP#1184yannickid wants to merge 1 commit into
yannickid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Bug 1: Port 80 listener toggle reports "already used" incorrectly
When Zoraxy itself holds port 80, the toggle to enable the HTTP
listener is greyed out with "Port 80 is already used by other services".
The check now correctly ignores Zoraxy's own listener.
Fix: reverseproxy.go:1569
if netutils.CheckIfPortOccupied(80) && !dynamicProxyRouter.GetPort80ListenerState()
Bug 2: Default Site ignored for unknown domains on port 80
When Force HTTPS is disabled, requests from unknown domains on port 80
always returned 404 NOT FOUND, ignoring the configured Default Site
option (Static Web Server, Redirect, etc.).
Fix: mod/dynamicproxy/dynamicproxy.go:167
router.mux.ServeHTTP(w, r) instead of http.NotFound(w, r)
Testing