Updates KDEpy to be Python 2 compatible#30
Conversation
The current version of the library only supports Python 3. Using some future imports and removing some type annotations, we make the library backwards compatible with Python 2.
|
Thanks a lot @theodoretliu . I'm interested in backwards compatibility in general - but more so to earlier versions of 3 than to Python 2, considering that Python 2 end of life is in a few months. Will look over this 👍 May I ask if you needed to run in on Python 2 yourself, and if so why? |
|
I have a few projects that still require Python 2 and your package! But I'm also happy to look at previous Python 3 version compatibility too! |
|
I used When I tested with 3.8.0b3+, there were failures, but they were with the installation of Let me know if there's anything else you would like tested out! |
|
Great. Thanks a lot! Since Python 2 reaches EOL soon, I will not merge this branch. I'd like to leave it open however. If someone needs a Py2 version, they can use the work in this branch 👍 |
tommyod
left a comment
There was a problem hiding this comment.
Looks good. Leaving it open in case it's useful for others needing a py2 compatible version.
The current version of the library only supports Python 3. Using some
future imports and removing some type annotations, this make the library
backwards compatible with Python 2.