fix: surface Uncategorized spending on the dashboard by separating uncategorized expenses from uncategorized income#88
Open
MarkIannucci wants to merge 1 commit into
Conversation
getRangeSummary netted income against expenses per category, so the Uncategorized catch-all — which mixes an un-ruled paycheck with real spending — collapsed to a negative total and was dropped from "spending by category" entirely, also understating headline Income/Expenses. Use a hybrid rule (in a shared summarizeBuckets helper): net real categories so refunds still reduce them, but split Uncategorized by flow (outflows are spending, inflows are income). Applied consistently across getRangeSummary, getTagSummary, queryFlexTotals, getSearchFilteredData, and queryCategoryTotals (delta mode), so every view reconciles. Net is unchanged. Tests: range/flex behavior, delta-mode alignment, and TUI+GUI dashboard reconciliation invariants (category lines sum to the Expenses total). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getRangeSummary netted income against expenses per category, so the Uncategorized catch-all — which mixes an un-ruled paycheck with real spending — collapsed to a negative total and was dropped from "spending by category" entirely, also understating headline Income/Expenses.
Use a hybrid rule (in a shared summarizeBuckets helper): net real categories so refunds still reduce them, but split Uncategorized by flow (outflows are spending, inflows are income). Applied consistently across getRangeSummary, getTagSummary, queryFlexTotals, getSearchFilteredData, and queryCategoryTotals (delta mode), so every view reconciles. Net is unchanged.
Tests: range/flex behavior, delta-mode alignment, and TUI+GUI dashboard reconciliation invariants (category lines sum to the Expenses total).