Fix to avoid exceeding concurrency in resource_limited_node#2103
Open
vossmjp wants to merge 1 commit into
Open
Fix to avoid exceeding concurrency in resource_limited_node#2103vossmjp wants to merge 1 commit into
vossmjp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The max concurrency of a node is not controlled by its concurrency parameter but by the number of resources it can acquire. The execution of resource_limited_body_leaf was limited but that body only starts the async process to by calling request on the various providers and then returns. So the previous implementation guards the request logic not the body execution.
This PR releases the takes the concurrency slot in the body_leaf but only releases it when the body completes.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information