Skip to content

ci: declare workflow-level contents: read on 4 workflows#900

Merged
jeongyoonlee merged 1 commit into
uber:masterfrom
arpitjain099:chore/declare-workflow-perms-readonly
May 16, 2026
Merged

ci: declare workflow-level contents: read on 4 workflows#900
jeongyoonlee merged 1 commit into
uber:masterfrom
arpitjain099:chore/declare-workflow-perms-readonly

Conversation

@arpitjain099
Copy link
Copy Markdown
Contributor

Pins the default GITHUB_TOKEN to contents: read on 4 workflows in .github/workflows/ that don't call a GitHub API beyond the initial checkout.

Why

CVE-2025-30066 (March 2025 tj-actions/changed-files supply-chain compromise) exfiltrated GITHUB_TOKEN from workflow logs. Pinning per workflow caps runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load on each touched file.

Pins the default GITHUB_TOKEN to contents: read on the workflows in
.github/workflows/ that don't call a GitHub API beyond the initial
checkout. The other workflows in this directory are left implicit
because they need write scopes that a maintainer is better placed
to declare.

Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files
compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow
caps bound runtime authority irrespective of repo or org default,
give drift protection if the default ever widens, and are credited
per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds workflow-level permissions: contents: read to four GitHub Actions workflows to restrict the default GITHUB_TOKEN scope, mitigating supply-chain attack risks like CVE-2025-30066.

Changes:

  • Adds permissions: contents: read block to 4 workflow files
  • No functional changes to job logic or steps

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/test-pypi-install.yml Adds workflow-level read-only token scope
.github/workflows/test-build-from-source.yml Adds workflow-level read-only token scope
.github/workflows/python-test.yaml Adds workflow-level read-only token scope
.github/workflows/black.yml Adds workflow-level read-only token scope

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeongyoonlee jeongyoonlee self-requested a review May 16, 2026 06:12
Copy link
Copy Markdown
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit 327200f into uber:master May 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants