fix(hint): remove resize listener in disableHintAutoRefresh()#2163
Open
shaked-shlomo wants to merge 1 commit into
Open
fix(hint): remove resize listener in disableHintAutoRefresh()#2163shaked-shlomo wants to merge 1 commit into
shaked-shlomo wants to merge 1 commit into
Conversation
disableHintAutoRefresh() called DOMEvent.on() for the 'resize' event instead of DOMEvent.off(), so disabling auto-refresh removed the 'scroll' listener but re-attached the 'resize' listener. The handler kept firing after being disabled and the reference was leaked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Pean Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
disableHintAutoRefresh()is supposed to remove thescrollandresizelisteners thatenableHintAutoRefresh()attaches. But theresizeline usesDOMEvent.oninstead ofDOMEvent.off:So after calling
disableHintAutoRefresh():scrolllistener is correctly removed, butresizelistener is re-attached (a duplicate is added), and thenthis._hintsAutoRefreshFunctionis set toundefined— leaking the listener so it can never be removed.This mirrors
enableHintAutoRefresh()just above, which correctly usesDOMEvent.onfor both events.Fix
Use
DOMEvent.offfor theresizeevent so both listeners are removed, matching the method's intent and its name.🤖 Generated with Claude Code