wwclient unitfile update#2203
Open
buzh wants to merge 2 commits into
Open
Conversation
added 2 commits
June 10, 2026 11:50
…slow, f.ex if networking takes a while to be ready. wwclient has internal retry logic, but the previous unit config didn't take this into account and would just kill the process after 60 seconds regardless, due to TimeoutSec being set. This PR changes the behaviour to wait forever on startup and allow up to 30s for service stops. It also adds Restart=on-failure so that if wwclient crashes or fails it won't require manual intervention to come back up should the cause of failure disappear. Stopping or killing wwclient will _not_ trigger a restart. In addition, the obsolete pidfile directive is removed.
…instead of terminating after 60s which can cause permanent failure f.ex on transient network issues. Attempt restarting if wwclient exits abnormally. Remove disused PIDFile directive. Signed-off-by: Andreas Skau <buzh@uio.no>
Collaborator
|
Thanks for the PR! The test suite is failing because of an upstream break in the container build process. That's fixed in a different PR, so I'll rebase this on that once it's in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Update unit file to avoid systemd terminating wwclient if startup is slow, f.ex if networking takes a while to be ready.
wwclient has internal retry logic, but the previous unit config didn't take this into account and would just kill the process after 60 seconds regardless, due to TimeoutSec being set.
This PR changes the behaviour to wait forever on startup and allow up to 30s for service stops.
It also adds Restart=on-failure so that if wwclient crashes or fails it won't require manual intervention to come back up should the cause of failure disappear. Stopping or killing wwclient will not trigger a restart.
In addition, the obsolete pidfile directive is removed and a documentation link is provided
Reviewer checklist
The reviewer checks the following items before merging the PR.
git commit --signoff) in agreement to the DCO