Rewriting READ/WRITE tests for the FLASH controller#952
Open
Patrick-Pataky wants to merge 26 commits into
Open
Rewriting READ/WRITE tests for the FLASH controller#952Patrick-Pataky wants to merge 26 commits into
Patrick-Pataky wants to merge 26 commits into
Conversation
Currently test 8 fails on verilator
- Ability to stop all tests at first failure - Fix: on error, current test case is always printed before the error message - Fix: test name inconsistencies
…ngle byte read test for each mode
…nd time overwritting previous data+single byte write tests for each mode
…t even for a write
This signal should be reset on every READ request, or on every new WRITE request (cross sector write)
from SW to HW
Allain18
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more extensive tests to test more cases, in a more regular way.
The library is also updated to be easier to use.
Format of the tests:
The write tests are very similar, with the addition of testing an overlapping write over the two sectors right after doing the first one. This allows to verify that the FSM resets for every write.