Skip to content

[tools/depends][target] Bump libxml 2.15.3#28339

Merged
fuzzard merged 1 commit into
xbmc:masterfrom
fuzzard:depends_libxml2
May 21, 2026
Merged

[tools/depends][target] Bump libxml 2.15.3#28339
fuzzard merged 1 commit into
xbmc:masterfrom
fuzzard:depends_libxml2

Conversation

@fuzzard
Copy link
Copy Markdown
Contributor

@fuzzard fuzzard commented May 18, 2026

Description

Bump libxml2 2.15.3

Motivation and context

Dependency bump

How has this been tested?

N/A

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@fuzzard fuzzard added this to the Piers 22.0 Beta 1 milestone May 18, 2026
@kodiai
Copy link
Copy Markdown
Contributor

kodiai Bot commented May 18, 2026 •
edited
Loading

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 2 changed files.
Review Details

  • Review plan: ready hash=514edc567694 route=tiny-diff task=review.small-diff files=2 lines=6(local-diff) budget=25t/521s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred

  • Review reducer: ready input=1 kept=0 suppressed=1 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=3 severityDemoted=1 graphValidated=0 graphUncertain=0

  • Review candidates: shadow recorded=1 rejected=0 errors=0 artifact=present repo=xbmc-xbmc pr=28339 key=kodiai-review-output:v1:inst-109141824:xbmc-xbmc:pr-28339:action-opened:delivery delivery=42d1c740-5258-11f1-84c4-8b387de2095f

  • Review candidate publication: mode=blocked approved=0 rewritten=0 published=0 directFallback=0 reasons=no-candidate-publication-path,approval-blocked

  • Files reviewed: 2

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +2 -4

  • Profile: strict (auto, lines changed: 6)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-operator-truth-paths candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=76c94fc5665c7e2a deliveryId=42d1c740-5258-11f1-84c4-8b387de… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:91d28d9895620354431b268e3a9b5de7; recordKey=candidate-publication-record:91d28d9895620354431b268e3a9b5de7; correlationKey=candidate-publication-bridge:dd0160cf5ba419a792e1a946e9a9d0e3; source=review-handler-publication; candidateRef=candidate-publication-summary-8a17e997; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • Review completed: 2026-05-18T01:29:19.560Z

  • Total wall-clock: 5m 13s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 19s
    • retrieval/context assembly: 17s
    • executor handoff: 3.5s
    • remote runtime: 4m 28s
    • publication: 2.6s

  • Tokens: 104 in / 10,095 out | 0.3195

  • Keyword parsing: No keywords detected

Filtered findings (1 finding removed — unverifiable claims)
  • LZMA dependency: verify default behavior in libxml2 2.15.3 — External knowledge claims: Version number '2.15.3' not found in diff content
Filtered findings (1 finding removed — unverifiable claims)
  • LZMA dependency: verify default behavior in libxml2 2.15.3 — External knowledge claims: Version number '2.15.3' not found in diff content

sundermann
sundermann reviewed May 18, 2026
View reviewed changes
Comment thread tools/depends/target/libxml2/Makefile
CMAKE_OPTIONS=-DBUILD_SHARED_LIBS=OFF \
-DLIBXML2_WITH_DEBUG=OFF \
-DLIBXML2_WITH_ICONV=OFF \
-DLIBXML2_WITH_LZMA=OFF \
Copy link
Copy Markdown
Contributor

@sundermann sundermann May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to take a dependency on xz for lzma in the parent makefile?

Copy link
Copy Markdown
Contributor Author

@fuzzard fuzzard May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LZMA support was removed, its no longer available in libxml as of 2.15.0

thexai
thexai approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@thexai thexai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is already being used on Windows.

@fuzzard fuzzard merged commit 3c16aa9 into xbmc:master May 21, 2026
2 checks passed
@fuzzard fuzzard deleted the depends_libxml2 branch May 21, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundermann sundermann sundermann approved these changes

@thexai thexai thexai approved these changes

Assignees

No one assigned

Labels

Component: Depends dependencies Pull requests that update a dependency file Platform: Android Platform: iOS Platform: macOS Platform: tvOS Platform: Wasm Platform: webOS Type: Improvement non-breaking change which improves existing functionality v22 Piers

Projects

None yet

Milestone

Piers 22.0 Beta 1

Development

Successfully merging this pull request may close these issues.

3 participants

@fuzzard @sundermann @thexai