Skip to content

Implement Account management#164

Open
wuriyanto48 wants to merge 8 commits into
xmppo:masterfrom
wuriyanto48:account-management
Open

Implement Account management#164
wuriyanto48 wants to merge 8 commits into
xmppo:masterfrom
wuriyanto48:account-management

Conversation

@wuriyanto48

Copy link
Copy Markdown

@wuriyanto48

Copy link
Copy Markdown
Author

@Neustradamus

Copy link
Copy Markdown
Member

@mattn, @mdosch: What do you think?

@mdosch

mdosch commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

I hope that I'll find some time within the next 2 months to do some tests. But as always in OSS, there is little time left between $dayjob and $familylife. ;)

@Neustradamus

Copy link
Copy Markdown
Member

@mdosch: Maybe you can look it?

@mdosch mdosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I added this questions some time ago but was not aware that only myself can see them as long as I do not submit the review.

Comment thread xmpp_account.go
}

// CreateAccount Creates a new account using the specified username, password and extra attributes
func (c *Client) CreateAccount(username string, password string, attributes map[string]string) error {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this supposed to work? I connect with account A and use this *Client to register account B?
I tried this and after sending the IQ I waited for 10s and nothing was sent back from the server (yax.im in my case).

Comment thread xmpp_account.go
return err
}

// SearchAccount search information repositories on the Jabber network.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is such a service? Any xmpp server? I'd need to know a search service that's known to work for testing purposes.

@Neustradamus

Copy link
Copy Markdown
Member

@wuriyanto48: Have you seen @mdosch comments?

2 similar comments
@Neustradamus

Copy link
Copy Markdown
Member

@wuriyanto48: Have you seen @mdosch comments?

@Neustradamus

Copy link
Copy Markdown
Member

@wuriyanto48: Have you seen @mdosch comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants