Skip to content

Dargon789 patch 9#205

Open
Dargon789 wants to merge 4 commits into
masterfrom
Dargon789-patch-9
Open

Dargon789 patch 9#205
Dargon789 wants to merge 4 commits into
masterfrom
Dargon789-patch-9

Conversation

@Dargon789

@Dargon789 Dargon789 commented Apr 5, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

Adjust hook execution to use process exit status directly, update release workflow branches, and add a changeset entry for a patch release.

Bug Fixes:

  • Use process exit status instead of full command output when running hooks to avoid unnecessary output handling.

CI:

  • Update release workflow to trigger only on pushes to the master branch.

Chores:

  • Add a changeset file documenting this patch release.

Dargon789 and others added 3 commits January 29, 2026 01:48
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Chores:

Record a patch release note for fnm attributed to Dargon789 patch 9.
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel

vercel Bot commented Apr 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fnm Ready Ready Preview, Comment Apr 5, 2026 2:26pm

@sourcery-ai

sourcery-ai Bot commented Apr 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switches hook execution from capturing full process output to only checking the exit status, simplifies the release workflow branch trigger, and adds a changeset entry for this patch release.

Class diagram for updated HooksManager hook execution logic

classDiagram
    class HooksManager {
        +execute_hook(hook_type)
    }

    class HookType {
        +name() String
    }

    class Command {
        +status() ExitStatus
    }

    class ExitStatus {
        +success() bool
        +code() int
    }

    class HookError {
    }

    class HookExecutionFailed {
        +hook_name String
        +exit_code int
    }

    HooksManager --> HookType : uses
    HooksManager --> Command : executes
    Command --> ExitStatus : returns
    ExitStatus --> HooksManager : evaluated_by
    HookError <|-- HookExecutionFailed : variant
    HooksManager --> HookError : returns_on_failure
Loading

File-Level Changes

Change Details Files
Update hook execution to use only the process exit status instead of capturing stdout/stderr.
  • Replace command.output() with command.status() to avoid capturing child process output buffers.
  • Adjust success check to use status.success() rather than output.status.success().
  • Propagate the exit code using status.code() in HookExecutionFailed errors.
src/hooks.rs
Limit the release GitHub Actions workflow to run only on pushes to master.
  • Remove main from the list of branches that trigger the release workflow on push.
.github/workflows/release.yml
Document this change as a patch release using Changesets.
  • Add a changeset file marking the fnm package for a patch version bump with a brief description of the change.
.changeset/popular-falcons-grab.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

snyk-io Bot commented Apr 5, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Confirm that removing the main branch from the release workflow trigger is intentional; if your default branch is main, releases will no longer run for that branch.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Confirm that removing the `main` branch from the release workflow trigger is intentional; if your default branch is `main`, releases will no longer run for that branch.

Fix all in Cursor


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mergify

mergify Bot commented Apr 5, 2026

Copy link
Copy Markdown

⚠️ The sha of the head commit of this PR conflicts with #203. Mergify cannot evaluate rules on this PR. Once #203 is merged or closed, Mergify will resume processing this PR. ⚠️

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hook execution logic in src/hooks.rs to use command.status() instead of command.output(), which avoids unnecessary output buffering since the output is already inherited. A review comment suggests improving the changeset description to provide a more meaningful summary of the changes for maintainers.

Comment thread .changeset/popular-falcons-grab.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@mergify

mergify Bot commented Apr 5, 2026

Copy link
Copy Markdown

⚠️ The sha of the head commit of this PR conflicts with #203. Mergify cannot evaluate rules on this PR. Once #203 is merged or closed, Mergify will resume processing this PR. ⚠️

@Dargon789 Dargon789 enabled auto-merge (squash) April 5, 2026 14:27

@Dargon789 Dargon789 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify

mergify Bot commented Apr 13, 2026

Copy link
Copy Markdown

⚠️ The sha of the head commit of this PR conflicts with #203. Mergify cannot evaluate rules on this PR. Once #203 is merged or closed, Mergify will resume processing this PR. ⚠️

@Dargon789 Dargon789 linked an issue Apr 15, 2026 that may be closed by this pull request
@mergify

mergify Bot commented May 23, 2026

Copy link
Copy Markdown

⚠️ The sha of the head commit of this PR conflicts with #203. Mergify cannot evaluate rules on this PR. Once #203 is merged or closed, Mergify will resume processing this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequence diagram for fnm env --use-on-cd eager initial use

1 participant