Dargon789 patch 9#205
Conversation
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Chores: Record a patch release note for fnm attributed to Dargon789 patch 9. Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSwitches hook execution from capturing full process output to only checking the exit status, simplifies the release workflow branch trigger, and adds a changeset entry for this patch release. Class diagram for updated HooksManager hook execution logicclassDiagram
class HooksManager {
+execute_hook(hook_type)
}
class HookType {
+name() String
}
class Command {
+status() ExitStatus
}
class ExitStatus {
+success() bool
+code() int
}
class HookError {
}
class HookExecutionFailed {
+hook_name String
+exit_code int
}
HooksManager --> HookType : uses
HooksManager --> Command : executes
Command --> ExitStatus : returns
ExitStatus --> HooksManager : evaluated_by
HookError <|-- HookExecutionFailed : variant
HooksManager --> HookError : returns_on_failure
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Confirm that removing the
mainbranch from the release workflow trigger is intentional; if your default branch ismain, releases will no longer run for that branch.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Confirm that removing the `main` branch from the release workflow trigger is intentional; if your default branch is `main`, releases will no longer run for that branch.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request updates the hook execution logic in src/hooks.rs to use command.status() instead of command.output(), which avoids unnecessary output buffering since the output is already inherited. A review comment suggests improving the changeset description to provide a more meaningful summary of the changes for maintainers.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Summary by Sourcery
Adjust hook execution to use process exit status directly, update release workflow branches, and add a changeset entry for a patch release.
Bug Fixes:
CI:
Chores: