Add random number to multishell symlinks (Schniz#1536) #217
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add possible values to the arch help docs. * add a changeset --------- Co-authored-by: Gal Schlezinger <gal@spitfire.co.il>
* docs: add e2e testing guide for agents * docs: trim AGENTS e2e section * docs: refine AGENTS guidance for e2e and changesets
* Add random number to multishell symlinks This protects against collisions when multiple shells are started in parallel inside Bubblewrap sandboxes, as each shell will have the same timestamp and the same low PID (e.g. 2), since Bubblewrap sandboxes have isolated PID spaces. * Add a changeset --------- Co-authored-by: Gal Schlezinger <gal@spitfire.co.il>
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
@joliss is attempting to deploy a commit to the Foundry development Team on Vercel. A member of the Team first needs to authorize it. |
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
There was a problem hiding this comment.
Code Review
This pull request introduces contributor documentation for E2E tests and changesets in AGENTS.md, and updates several dependencies including adding fastrand. The Arch enum now derives ValueEnum to provide possible values in help documentation. Additionally, generate_symlink_path was updated to include a random number to prevent symlink collisions in multishell environments. Feedback was provided regarding the ValueEnum derivation, suggesting explicit naming to avoid potential mismatches with manual string implementations if variant names change.
| use clap::ValueEnum; | ||
|
|
||
| #[derive(Clone, Copy, PartialEq, Eq, Debug)] | ||
| #[derive(Clone, Copy, PartialEq, Eq, Debug, ValueEnum)] |
There was a problem hiding this comment.
While deriving ValueEnum is a great way to expose possible values to clap, the default renaming strategy (kebab-case) might not perfectly match your manual FromStr and as_str implementations for all variants. For example, X64Glibc217 would default to x64-glibc-217 in kebab-case, which matches your manual implementation, but it's safer to be explicit to avoid future regressions if variant names change.
No description provided.