Make Init() for worker pool implicit.#3703
Open
jaredjenkins wants to merge 1 commit into
Open
Conversation
Having to call Init is just really awakward. You should be able to call the factory and expect the worker pool to be started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3703 +/- ##
========================================
- Coverage 56.7% 56.7% -0.1%
========================================
Files 553 553
Lines 62705 62705
========================================
- Hits 35581 35564 -17
- Misses 23948 23967 +19
+ Partials 3176 3174 -2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to call Init is just really awakward. You should be able to call
the factory and expect the worker pool to be started. This is a no-op change for now.
Eventually, we'll make Init a private method.