Skip to content

metal: implement multisample resolve textures #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benface wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −3
Open

metal: implement multisample resolve textures #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/graphics/metal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,12 @@ impl RenderingBackend for MetalContext {
resolve_img: Option<&[TextureId]>,
depth_img: Option<TextureId>,
) -> RenderPass {
if resolve_img.is_some() {
unimplemented!("resolve textures are not yet implemented on metal");
if let Some(resolve_img) = resolve_img {
assert_eq!(
resolve_img.len(),
color_img.len(),
"resolve_img must have one entry per color attachment"
);
}
unsafe {
let render_pass_desc =
Expand All @@ -552,7 +556,19 @@ impl RenderingBackend for MetalContext {
let color_attachment = msg_send_![msg_send_![render_pass_desc, colorAttachments], objectAtIndexedSubscript:i];
msg_send_![color_attachment, setTexture: color_texture];
msg_send_![color_attachment, setLoadAction: MTLLoadAction::Clear];
msg_send_![color_attachment, setStoreAction: MTLStoreAction::Store];
// Multisample resolve: when the caller passes a resolve
// texture for this attachment, downsample into it on
// store. Required for any MSAA render target.
if let Some(resolve_img) = resolve_img {
let resolve_texture = self.textures.get(resolve_img[i]).texture;
msg_send_![color_attachment, setResolveTexture: resolve_texture];
msg_send_![
color_attachment,
setStoreAction: MTLStoreAction::MultisampleResolve
];
} else {
msg_send_![color_attachment, setStoreAction: MTLStoreAction::Store];
}
}
if let Some(depth_img) = depth_img {
let depth_texture = self.textures.get(depth_img).texture;
Expand Down
Loading