fix: pp.deep resolves free vars inside nested function scopes#78
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pp.deepcompiles and evaluates the expression witheval(code, frame.f_globals, frame.f_locals), but generator expressions, comprehensions, and nested lambdas inside the expression run in their own function scope where the eval frame's locals are not visible, so any reference to an enclosing-function variable raisesNameError(reported as!!! NameError!in the output and re-raised, issue #75). This mergesf_localsinto the globals dict passed toevalso those names resolve via the eval frame's globals from any nested scope, and stops mutating the caller'sf_globalsfor the wrapper hooks.Closes #75